Skip to content

Style remarks like definitions (minimal, not foldable) - #82

Merged
d-morrison merged 1 commit into
mainfrom
claude/kind-knuth-4595c0-remark-style
Sep 29, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/kind-knuth-4595c0-remark-style

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Why

Remarks rendered as default-appearance callouts, with a shaded "Remark" title band, a fold toggle, and the inline "Remark." label repeated underneath. Readers see remarks right next to definitions and results, so remarks should look like them.

What

The remark entry under callouty-theorem now matches def and the result types:

  • appearance: minimal, which keeps only the colored left border
  • override-title: false, so the inline "Remark." is the only label
  • no collapse or icon

Only the HTML config changes. Remarks that are also speaker notes (.remark .notes) still render as notes on the slides.

The same one-block change is going to every Morrison-Lab Quarto repo with this config. Morrison-Lab/pds#29 is the reference PR, where it was checked by rendering a page and inspecting the result in a browser.

🤖 Generated with Claude Code

https://claude.ai/code/session_014YzWJF4E24Edb6RKXbkWaH


Generated by Claude Code

Remarks rendered as default-appearance callouts: a shaded title band
reading "Remark", a fold toggle, and the inline "Remark." label from
callouty-theorem repeated underneath. They now use the same minimal
appearance as definitions and results: only the colored left border,
with the inline label as the only heading. Only the HTML config
changes; reveal.js speaker notes (.remark .notes) are unaffected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014YzWJF4E24Edb6RKXbkWaH
@github-actions

Copy link
Copy Markdown

Caution

Claude review did not run: the configured API credential is unusable.

No review ran at all, so this PR has not been reviewed. This comment exists so that fact is visible from the PR itself rather than only from the run log (gha#543).

The pre-flight check found that every configured API credential secret carries whitespace inside its value, so it cannot be sent as an HTTP Authorization header. The request would be rejected at the door, so the review was not attempted and no money was spent.

This is a repository configuration defect rather than anything about the diff. Nothing about this PR needs to change, and re-running the workflow will fail identically until the secret is repaired.

A repository admin fixes it under Settings -> Secrets and variables -> Actions by re-setting CLAUDE_CODE_OAUTH_TOKEN (or ANTHROPIC_API_KEY) to a single-line value with no spaces or line breaks. The usual cause is pasting a multi-line block -- a PEM key, a JSON credential file, a wrapped terminal copy -- where the token belongs. claude setup-token prints a fresh token to copy.

The Pre-flight credential shape check step in the linked run names which secret is affected and where the whitespace falls, without printing the value itself.

Until an external verdict lands, this PR is not clean. The red require-review is correct rather than a flake, and a self-review stands in for the missing verdict without replacing it.

View run

Copy link
Copy Markdown
Contributor Author

review / claude-review, require-review and require-clean-verdict are red because the review never ran. The workflow's pre-flight check found whitespace inside the repository's CLAUDE_CODE_OAUTH_TOKEN (or ANTHROPIC_API_KEY) secret, so the request couldn't be sent. That's a repo configuration problem, not something this one-block YAML change can fix, and a re-run fails the same way. A repo admin needs to re-set the secret as a single-line value. After that, a re-run of the review workflow will review this PR.


Generated by Claude Code

@d-morrison
d-morrison merged commit 42b4333 into main Sep 29, 2026
9 of 12 checks passed
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-29 00:35 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants