Skip to content

Bump latex-macros so the logistic function prints as expit - #132

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-gz6w0h
Oct 25, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-gz6w0h

Conversation

@d-morrison

@d-morrison d-morrison commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Bumps the latex-macros pin to 117c0b9, the current macros main. The pin was behind macros#294, which makes \sigmoid and \sigmoidf print upright expit instead of σ, which also prints a standard deviation, a bandwidth and a singular value. The names stay as permanent aliases (macros#295), so no source change is needed.

I searched the .qmd, .md and .Rmd files for a raw \sigma( used as the logistic function and found none. This repo's .gitmodules still points the submodule at d-morrison/macros; I left that URL alone. Pin-only change; not rendered locally.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DcoxKs4KBbN2HfeyoeUw5h

The pin was behind the macros change that prints the logistic function as
upright expit (macros#294, #295), so \sigmoid and \sigmoidf here still printed
a sigma. The bump is the gitlink alone.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DcoxKs4KBbN2HfeyoeUw5h
Copilot AI balanced review requested due to automatic review settings October 25, 2026 03:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown

Claude finished review — View run


Review: PR #132 — Bump latex-macros so the logistic function prints as expit

Change: latex-macros (d-morrison/macros) gitlink bumped from 16a84f9 → 117c0b9 in latex-macros:1. That's the entire diff — no .qmd/.md/.R changes.

Verification performed:

  • Confirmed macros#294 ("Print the logistic function as upright expit") and macros#295 ("Record that the sigmoid aliases are permanent") are real, merged PRs in d-morrison/macros — not hallucinated.
  • Confirmed the checked-out submodule at the new pin defines \def\sigmoid{\expit} and \providecommand{\sigmoidf}[1]{{\expit\paren{#1}}} (latex-macros/macros.qmd:347-348), i.e. both names are now permanent aliases that render upright expit rather than σ, matching the PR description.
  • Searched this repo's .qmd/.md/.Rmd files for raw \sigma( used as the logistic function: none found. The one \sigma hit (chapters/12-ip-weighting-marginal-structural-models.qmd:697) is $\sigma^2$ for a residual variance, an unrelated, legitimate use — so the author's claim that no source change is needed is correct.
  • .gitmodules still points at https://github.com/d-morrison/macros.git, unchanged, as the description states.

LaTeX macro checks: No math was added or changed in this diff (only a submodule SHA changed), so neither the simplification-opportunity nor new-macro-candidate check applies here.

SERG lab manual / coding style: N/A — no R or Quarto source changed, just a vendored submodule pin.

No issues found; this is a correct, well-documented, minimal-scope submodule bump.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "d041ffe5a02322aef59033d434ee1c0e0535333c",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path is the latex-macros gitlink; the new pin's macros.qmd verifiably defines sigmoid and sigmoidf as permanent expit aliases, so no rendering regression is possible from this change.",
  "holistic_assessment": "Scope is a single submodule pointer bump with no source edits required, integration with the win repo's existing sigma usage is unaffected, and the author's search claim was independently reproduced and confirmed."
}

Reviewed commit: fc7e1f8

@github-actions

Copy link
Copy Markdown

💰 Cost: $0.2648 (review) — run

@d-morrison
d-morrison merged commit 42258c8 into main Oct 25, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-25 04:56 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants