Repository navigation
Bump latex-macros so the logistic function prints as expit - #132
Merged
Merged
Conversation
The pin was behind the macros change that prints the logistic function as upright expit (macros#294, #295), so \sigmoid and \sigmoidf here still printed a sigma. The bump is the gitlink alone. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DcoxKs4KBbN2HfeyoeUw5h
|
Claude finished review — View run Review: PR #132 — Bump latex-macros so the logistic function prints as expitChange: Verification performed:
LaTeX macro checks: No math was added or changed in this diff (only a submodule SHA changed), so neither the simplification-opportunity nor new-macro-candidate check applies here. SERG lab manual / coding style: N/A — no R or Quarto source changed, just a vendored submodule pin. No issues found; this is a correct, well-documented, minimal-scope submodule bump. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "d041ffe5a02322aef59033d434ee1c0e0535333c",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only changed path is the latex-macros gitlink; the new pin's macros.qmd verifiably defines sigmoid and sigmoidf as permanent expit aliases, so no rendering regression is possible from this change.",
"holistic_assessment": "Scope is a single submodule pointer bump with no source edits required, integration with the win repo's existing sigma usage is unaffected, and the author's search claim was independently reproduced and confirmed."
}Reviewed commit: fc7e1f8 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ezra · project thread
Bumps the
latex-macrospin to 117c0b9, the current macrosmain. The pin was behind macros#294, which makes\sigmoidand\sigmoidfprint uprightexpitinstead of σ, which also prints a standard deviation, a bandwidth and a singular value. The names stay as permanent aliases (macros#295), so no source change is needed.I searched the
.qmd,.mdand.Rmdfiles for a raw\sigma(used as the logistic function and found none. This repo's.gitmodulesstill points the submodule atd-morrison/macros; I left that URL alone. Pin-only change; not rendered locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01DcoxKs4KBbN2HfeyoeUw5h