Repository navigation
Box ch. 11 content into numbered divs and callouts - #126
Open
d-morrison wants to merge 7 commits into
Open
d-morrison wants to merge 7 commits into
d-morrison wants to merge 7 commits into
Conversation
Part of #77. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
|
Claude finished review — View run Review: PR #126 — Box ch. 11 content into numbered divs and calloutsScope: Restructures Verification performed
FindingsNone. This is a careful, well-scoped restructuring that preserves all existing IDs/headings (confirmed VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "f3af2340c8b7d755cbd170f9d70ebaac468bc6ec",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked chapters/11-why-model.qmd for balanced fenced divs, resolvable cross-references, and correct arithmetic in the CI-width and predicted-value calculations; found no broken refs, no unbalanced divs, and the rounding-discrepancy fix in exm-linear-model is mathematically sound.",
"holistic_assessment": "Verified the new div/callout/proof conventions, tbl-two-models caption pattern, and cross-chapter link style all match existing usage across chapters 02-23, and inst/WORDLIST remains case-insensitively sorted after the invertible addition, so integration and repo conventions are satisfied with no regression risk."
}Reviewed commit: 8e40f0b |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ezra · project thread
Part of #77
Before: ch. 11 (why model?) had 2 definitions and 3 examples in numbered divs. Most of the chapter was plain prose, bullet lists, or speaker notes. Fine Points 11.1-11.2 and Technical Point 11.1 were callouts that mixed definitions and claims, so none of them could be cross-referenced.
After: 52 numbered boxes. Every definition comes before its first use.
def-saturated-modelanddef-nonparametric-estimatorare kept. The saturated-model definition now says when counting parameters works.exm-linear-model,exm-saturatedandexm-quadratic-modelare kept. The HIV setting (each figure uses its own 16-person data set), the three treatment codings, and link functions are new.tbl-two-models)..callout-notewith a short intro, and its definitions and remarks follow as sibling divs. No div sits inside a callout or.notes. Win#122 added no ch. 11 callouts, and none were missing.sec-bias-variancetoo). One added word, invertible, went intoinst/WORDLIST.How: existing text was wrapped, and wording that tracked the book closely was paraphrased. An 8-gram check against
pdftotextof the chapter leaves only two short quoted, cited phrases.Corrections found in review:
Checks:
quarto render chapters/11-why-model.qmdto html, docx and revealjs succeeds with no warnings, and there are no unresolved?@refs. PDF could not be rendered locally because TeX is not installed. No div title contains math.check-new-line-breakspasses on the added lines.##headings, which are left so the anchors stay stable.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Generated by Claude Code