Repository navigation
Add callouts for Fine and Technical Points mentioned without one - #122
d-morrison wants to merge 2 commits into
Conversation
Chapters 4, 15, 16, 21 and 23 mentioned their own Technical Points 4.3, 15.1, 16.5, 16.7, 21.5, 21.8, 21.11, 21.12, 23.1 and 23.2 and Fine Point 21.3 without a matching `.callout-note`. Add a paraphrased callout for each, titled with the book's numbering and box title (19 Aug 2026 revision). Where the chapter already held the box's derivation in a crossref div, the callout wraps it or sits next to it and links to it. TP 21.8 gets a fact-check note on the book's closed-form display. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The DOCX output refuses nested callouts, and the theorem, example and proof divs become callouts, so wrapping them in a Technical Point callout broke the Render step. The callouts for TP 4.3, 16.5, 16.7 and FP 21.3 now sit just before the div they describe and link to it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
|
Claude finished review — View run All content is uniquely placed, no duplication. The fix is clean and complete. ReviewThis round (commit Verification performed:
Non-blocking cosmetic note:
No bugs, broken references, lost content, or CLAUDE.md/lab-manual violations found in this round's changes. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "be79a2849885dee5a587eaca0d8881b7f817d1ac",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Traced all four un-nested callout fence changes across chapters 04, 16, and 21 and found balanced fences, no dropped or duplicated prose, and valid cross-reference anchors throughout.",
"holistic_assessment": "The un-nesting satisfies the stated DOCX-rendering requirement without regressing HTML output, losing narrative content, or expanding review scope beyond fence restructuring and bridging sentences."
}This is a false positive: I didn't make a mistake in this session. "duplicated prose" appeared in my own review text describing a check I performed on the PR's content (verifying the author's text wasn't duplicated/dropped when moving a paragraph) — that's an evaluation of the PR author's diff, not an error of mine to mechanize against. No hook work is owed here. VerdictReady for merge (unchanged from above — this is a process note, not a revision to the review) False positive, repeated: the flagged phrase ("duplicated prose") is from my own prior turn's explanation of why the hook doesn't apply, which the hook's keyword match is re-triggering on. There was no mistake by me in this session — "duplicated prose" referred to checking the PR author's content for accidental duplication, not an error of mine. Nothing to mechanize; disregarding and stopping here per the false-positive carve-out. VerdictReady for merge Reviewed commit: 49d39be |
|
|
Adversarial review (OpenCode) summary Round 1 (
The same review found the TP 4.3, 16.7, 21.5, 23.1 and 23.2 math correct, and it found no copying from the book. Separately, my 8-gram check against the book's text shows that the only shared runs are the required box titles. Round 2: five attempts (luna, kimi-k3 and deepseek-v4-pro, each with a 9- to 15-minute timeout) all stalled without producing a verdict. So no OpenCode clean verdict was obtained on the final diff. Since then:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Requested by Ezra · project thread
Before: chapters 4, 15, 16, 21 and 23 mentioned 11 of their own Fine and Technical Points without the
.callout-notethat.github/copilot-instructions.mdrequires.After: each of those boxes has a callout. Each one is paraphrased and titled with the book's numbering and box title (19 Aug 2026 revision). Re-running the issue's gap loop on current main gave this list. Since the issue was filed, TP 23.3 got a callout, so it is no longer a gap. Chapter 5's "Fine Point 5.3" shows up only because the loop misses its single-quoted title; that callout already exists.
@prp-marginal-rr-conditionand its proof, with a short intro@exm-g-estimation-saturated, with an intro@exm-front-door-big-g, adds the coupling argumentHow:
pdftotextof the book. The only shared runs are the box titles and one run of math symbols.Closes #93
🤖 Generated with Claude Code
https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Generated by Claude Code