Repository navigation
Box ch. 6 content into numbered divs and callouts - #119
d-morrison wants to merge 3 commits into
Conversation
Put chapter 6's definitions, results, examples, remarks, cautions and tips into crossref divs and callouts. Definitions now precede first use (DAG, parents and descendants, causal DAG, Markov property, NPSEM, NPSEM-IE, FFRCISTG, blocked paths, d-separation, faithfulness, causal discovery, the bias types, surrogate effect modifiers), each followed by a concrete example. New propositions state the Markov factorization (with proof), that every NPSEM-IE is an FFRCISTG but not conversely (with proof and a counterexample), and that both models imply the causal Markov assumption; Pearl's d-separation theorem is boxed with its conditions. Collider-conditioning claims are hedged as generic, with a warning that the diagram does not fix the sign. Part of #77. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
…ations, reword close paraphrases Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
|
Adversarial review (OpenCode, gpt-5.6-luna), round 1 on 7cc9476: 8 findings, not clean. Each one is addressed in 2a8417a:
Round 2 could not run. Every OpenCode Go model (gpt-5.6-luna, kimi-k3, deepseek-v4-pro) now fails with Local checks on 2a8417a:
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
/review Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rebutting the one finding in the latest Claude review ( Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
/review Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
|
Claude finished review — View run Review: PR #119 — Box ch. 6 content into numbered divs and calloutsThis round reviews the range computed by the workflow, The fix for the sole outstanding finding has been applied and verified correct. The prior two review rounds (round 1, round 2) flagged This commit rewords the sentence to:
I checked this directly:
No other content changed in this range, and the rest of the diff (crossrefs, proofs, citations, div structure, macro usage) was already verified clean across the two prior rounds and remains unchanged here. No d-morrison/macros opportunities apply to this one-line prose edit; no new/changed math was introduced. No new issues found. VerdictReady for merge — the single outstanding issue from prior rounds (likely CI spellcheck failure from unlisted plurals) has been resolved by rewording to avoid the plural acronyms, verified against Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "56114369d2cb10db26f3f6ddb8c476345a761a51",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "chapters/06-graphical-representation.qmd:431 now reads 'some models that satisfy the FFRCISTG condition are not NPSEM-IE models', avoiding the unlisted plural acronyms FFRCISTGs and NPSEM-IEs that would have failed check-spelling CI in prior rounds.",
"holistic_assessment": "Validation scope is limited to this single-line wording fix; wordlist entries for FFRCISTG, NPSEM, and IE confirm the singular forms used now resolve cleanly with no regression to crossref or proof content reviewed earlier."
}Reviewed commit: 403bc16 |
|
Requested by Ezra · project thread
Part of #77: ch. 6 (graphical representation of causal effects).
Before: ch. 6 had only a few divs (causal Markov, path, collider, systematic bias, and five examples). Most terms were bold words in prose or sat inside Technical Point and Fine Point callouts. Several were used before they were defined. For example, "parents" and "non-descendants" appeared in the causal Markov definition but were defined only later, in Technical Point 6.1.
After: 57 numbered boxes, each defined before first use. Each new definition is followed by a concrete example.
No theorem div sits inside a callout or
.notes. The Technical Point and Fine Point callouts now hold short summaries and point to the boxes that follow them, as ch. 12 does.How: I wrapped the existing text, following the merged ch. 8 (#109) and ch. 10 (#110) passes and the review findings they received.
#bias-under-the-null,#from-d-separation-to-independence).Checks:
quarto render chapters/06-graphical-representation.qmd --to htmlsucceeds with no warnings, and the page has no unresolved?@references.inst/WORDLISTis unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK