Repository navigation
Box ch. 5 content into numbered divs and callouts - #118
d-morrison wants to merge 6 commits into
Conversation
Part of #77. Definitions, results, examples and exercises in the interaction chapter now sit in numbered theorem divs or callouts, each definition before first use and followed by an example, and each proposition stating its conditions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Put tables before the examples that cite them, state the independence and positivity conditions behind the allergy-prevalence example, define sufficient cause interaction through background factors, and reword the framework comparison in our own words. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
… proposition Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
This comment has been minimized.
This comment has been minimized.
|
|
Adversarial review log (OpenCode Go), standing in while the Claude review is 429 quota-limited Five rounds ran on
Rebutted:
A confirming round 6 on head c1f4a8a could not run: from about 09:30 UTC, OpenCode Go stopped answering for all three models, and even a one-word smoke test timed out. Round 6 and the Claude review are still owed on this head. Render: Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
/review Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Claude finished review — View run I re-verified the CI/review status using the authoritative instrument rather than relying on the shorter I ran I checked the script's internals ( The one gap this tool flags — no review comment evaluating this exact HEAD SHA exists yet — is structural to this being the first Claude review posted against this PR (confirmed earlier: the only prior PR comments are 429-quota notices, the preview bot, and d-morrison's own adversarial-review log, none of which is a Claude verdict on Given that CI is confirmed fully clean via the complete instrument, and my own content review (math verification, crossref/structural checks, lab-manual and macro checks) found zero blocking issues, my verdict below is my own first review verdict for this PR — not a claim that a prior clean verdict already existed. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c1f4a8a2cb97a465b4624a395ed4ef8766d98487",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Hand-verified the new interaction-contrast table, the additive-decomposition and sufficient-cause proofs, and the allergy-prevalence example in chapters/05-interaction.qmd; all arithmetic and logic check out with no broken crossrefs or nested divs.",
"holistic_assessment": "Scope matches the stated ch.5 restructuring goal, integrates correctly with ch.2 and ch.4 cross-references, follows the latex-macros submodule conventions, and check-pr-fully-clean.py confirms all CI check-runs pass on this exact head commit via the complete paginated endpoint."
}Re-queried fresh (not relying on the earlier tool result): head SHA is still So, to be precise and avoid overloading the term: the PR's CI is fully green (13/13 non-skipped checks pass, 0 pending, 0 failing, confirmed by both VerdictReady for merge (CI: 13 checks pass, 0 failing, 0 pending, on current head Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c1f4a8a2cb97a465b4624a395ed4ef8766d98487",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Hand-verified the new interaction-contrast table, the additive-decomposition and sufficient-cause proofs, and the allergy-prevalence example in chapters/05-interaction.qmd; all arithmetic and logic check out with no broken crossrefs or nested divs.",
"holistic_assessment": "Scope matches the stated ch.5 restructuring goal, integrates correctly with ch.2 and ch.4 cross-references, follows the latex-macros submodule conventions, and a fresh gh pr checks query confirms 13 checks pass with 0 failing and 0 pending on head c1f4a8a2."
}Reviewed commit: c1f4a8a |
Requested by Ezra · project thread
Part of #77: ch. 5 (interaction).
Before: ch. 5 had 9 numbered divs. Most of its definitions, results and examples sat in plain prose, inside Technical/Fine Point callouts, or only in speaker notes, so they had no number and could not be cross-referenced.
After: each one sits in a numbered div or a callout.
How: existing text was wrapped rather than rewritten where possible. Material that lived only in speaker notes but was used later (recursive substitution, the vitamin-effect calculation, exchangeability via component causes, the Zeus double counting) is now visible. The looking-up note said Chapter 1; it is Chapter 2 and now says so. No theorem div sits inside a callout or another div. Cross-chapter references use links, since this is a website, not a book. Every new crossref id was checked to be unique across all chapters.
Checks:
quarto render chapters/05-interaction.qmd --to htmlsucceeds with no warnings, and the page has no unresolved?@references.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Generated by Claude Code