Skip to content

Drop chalkboard from the self-contained RevealJS profile - #116

Open
d-morrison wants to merge 2 commits into
mainfrom
claude/fix-revealjs-chalkboard-94
Open

d-morrison wants to merge 2 commits into
mainfrom
claude/fix-revealjs-chalkboard-94

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Before: quarto render --profile revealjs failed with ERROR: Reveal plugin 'RevealChalkboard is not compatible with self-contained output, because _quarto-revealjs.yml set both embed-resources: true and chalkboard: true.

After: the standalone profile (documented in the README as the self-contained slides profile writing to _slides/) drops chalkboard.
The website profile, which is what gets published and already has embed-resources: false, keeps the chalkboard.
A comment in the profile and a README note document how to get the chalkboard in the standalone profile instead (embed-resources: false plus chalkboard: true).

How verified: quarto render chapters/01-introduction.qmd --profile revealjs --to revealjs errors on main and writes _slides/chapters/01-introduction-slides.html on this branch.

Closes #94

🤖 Generated with Claude Code

https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK


Generated by Claude Code

claude added 2 commits October 9, 2026 08:42
Quarto refuses chalkboard together with embed-resources: true,
so 'quarto render --profile revealjs' failed before writing any slide.
The standalone profile is for self-contained files; the website profile keeps the chalkboard.

Closes #94

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Copilot AI balanced review requested due to automatic review settings October 9, 2026 08:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@d-morrison d-morrison self-assigned this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Claude finished review — View run


No prior Claude review exists on this PR, so this is a first-pass review.

Review: Drop chalkboard from the self-contained RevealJS profile (PR #116)

Scope. Two-file, 39-line diff: _quarto-revealjs.yml (removes chalkboard: true from the standalone/self-contained slides profile, adds an explanatory comment) and README.md (documents the limitation). No code, tests, or .qmd content changed.

Correctness. Verified independently:

  • _quarto-website.yml:186 sets embed-resources: false and _quarto-website.yml:201 sets chalkboard: true — confirming the PR's claim that the website profile already uses the only combination compatible with the chalkboard plugin.
  • _quarto.yml (the shared base config) sets no chalkboard/embed-resources values that would leak into either profile, so the fix is correctly isolated to the standalone profile without affecting the website profile.
  • Quarto's RevealChalkboard plugin requires external asset files and is documented as incompatible with embed-resources: true (self-contained output) — this is a known, real Quarto/RevealChalkboard limitation, not a fabricated constraint. The fix (dropping chalkboard from the self-contained profile and keeping it in the non-self-contained website profile) is the correct and minimal resolution.
  • Quarto itself wasn't available in this sandbox to re-run the exact quarto render --profile revealjs repro from the PR description, but the YAML diff alone is sufficient to confirm the logical fix is sound given the configs above.

Lab manual / style check. The README addition is a single bullet continuation line — renders correctly as a nested paragraph under the existing bullet, no raw HTML, no broken markdown. The YAML comment is clear and explains both what changed and how to opt back into the chalkboard (via embed-resources: false), which is good practice per the coding style guide on comments explaining the "why." No raw LaTeX/math touched, so no macro-opportunity findings apply.

Macro check. latex-macros submodule is present (.gitmodules → d-morrison/macros) with latex-macros/macros.qmd, but this diff contains no LaTeX/math content — nothing to check against it.

Minor, non-blocking note. The word "chalkboard" is now added to README.md prose (previously it only appeared inside a .yml file, which the check-spelling.yaml workflow likely doesn't scan). "Chalkboard" is a standard English dictionary word, so this is very unlikely to trip the spelling-package CI check, and I did not reproduce a failure — flagging only in case CI surprises the author.

Hallucination check. No invented functions, APIs, or fabricated citations. The PR description's technical claim about RevealChalkboard vs. embed-resources: true matches a real, documented Quarto limitation and is consistent with what's in the repo's own configs.

No blocking issues found.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "37252a7",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Reviewed _quarto-revealjs.yml and README.md changes, confirmed chalkboard removal from self-contained profile avoids the documented RevealChalkboard embed-resources conflict without touching the website profile's own chalkboard setting.",
  "holistic_assessment": "Change is scoped exactly to the linked issue, keeps website profile behavior unchanged, adds explanatory documentation, and introduces no regression risk across other render profiles."
}

Reviewed commit: 6bd2c7d

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

💰 Cost: $0.3066 (review) — run

Copy link
Copy Markdown
Collaborator Author

OpenCode adversarial review (deepseek-v4-pro; gpt-5.6-luna stalled on tool calls): round 1 found comment-wording nits, fixed in 6bd2c7d; round 2 on the final diff: VERDICT: clean.
Verified quarto render chapters/01-introduction.qmd --profile revealjs --to revealjs errors on main and succeeds on this branch.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Morrison-Lab.github.io/win/pr-preview/pr-116/

Built to branch gh-pages at 2026-10-09 09:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RevealJS profile fails: chalkboard is incompatible with embed-resources

3 participants