Repository navigation
Drop chalkboard from the self-contained RevealJS profile - #116
d-morrison wants to merge 2 commits into
Conversation
Quarto refuses chalkboard together with embed-resources: true, so 'quarto render --profile revealjs' failed before writing any slide. The standalone profile is for self-contained files; the website profile keeps the chalkboard. Closes #94 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
|
Claude finished review — View run No prior Claude review exists on this PR, so this is a first-pass review. Review: Drop chalkboard from the self-contained RevealJS profile (PR #116)Scope. Two-file, 39-line diff: Correctness. Verified independently:
Lab manual / style check. The README addition is a single bullet continuation line — renders correctly as a nested paragraph under the existing bullet, no raw HTML, no broken markdown. The YAML comment is clear and explains both what changed and how to opt back into the chalkboard (via Macro check. Minor, non-blocking note. The word "chalkboard" is now added to Hallucination check. No invented functions, APIs, or fabricated citations. The PR description's technical claim about No blocking issues found. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "37252a7",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Reviewed _quarto-revealjs.yml and README.md changes, confirmed chalkboard removal from self-contained profile avoids the documented RevealChalkboard embed-resources conflict without touching the website profile's own chalkboard setting.",
"holistic_assessment": "Change is scoped exactly to the linked issue, keeps website profile behavior unchanged, adds explanatory documentation, and introduces no regression risk across other render profiles."
}Reviewed commit: 6bd2c7d |
|
OpenCode adversarial review (deepseek-v4-pro; gpt-5.6-luna stalled on tool calls): round 1 found comment-wording nits, fixed in 6bd2c7d; round 2 on the final diff: VERDICT: clean. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Requested by Ezra · project thread
Before:
quarto render --profile revealjsfailed withERROR: Reveal plugin 'RevealChalkboard is not compatible with self-contained output, because_quarto-revealjs.ymlset bothembed-resources: trueandchalkboard: true.After: the standalone profile (documented in the README as the self-contained slides profile writing to
_slides/) dropschalkboard.The website profile, which is what gets published and already has
embed-resources: false, keeps the chalkboard.A comment in the profile and a README note document how to get the chalkboard in the standalone profile instead (
embed-resources: falsepluschalkboard: true).How verified:
quarto render chapters/01-introduction.qmd --profile revealjs --to revealjserrors onmainand writes_slides/chapters/01-introduction-slides.htmlon this branch.Closes #94
🤖 Generated with Claude Code
https://claude.ai/code/session_01Gh7L9vJhwrpvpBhzYMdjPK
Generated by Claude Code