Skip to content

fix: remove empty and title-only slides across revealjs decks (closes #16) - #53

Merged
dem-extra1 merged 2 commits into
mainfrom
fix/empty-slide-derivatives
Sep 30, 2026
Merged

dem-extra1 merged 2 commits into
mainfrom
fix/empty-slide-derivatives

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #16

Summary of Changes

  • Calculus Deck (calculus.qmd): Relocated {{< include latex-macros/macros.qmd >}} from above ## Derivatives {#sec-derivatives} to immediately below it, eliminating the empty <section class="slide level2"> rendered between the title slide and the Derivatives slide.
  • Linear Algebra Deck (linear-algebra.qmd & _subfiles/_sec_linear_algebra.qmd): Removed the macros include above the first fragment in linear-algebra.qmd and moved it under ## Vectors in _subfiles/_sec_linear_algebra.qmd, eliminating the empty initial slide. Updated index.qmd fragment documentation accordingly.
  • Algebra Deck (_algebra.qmd): Moved ## Equalities to line 1 ahead of the speaker-notes prereq block and macros, attaching the notes directly to the first slide and removing the empty/speaker-notes-only slide.
  • Notation Deck (_notation.qmd): Removed the redundant {{< slidebreak >}} immediately after ## Natural numbers {#sec-notation-naturals}, rendering the exercise on the section slide rather than leaving a title-only slide.
  • Proof Writing Deck (proof-writing.qmd): Removed the trailing ## References {.unnumbered} with empty ::: {#refs} since proof-writing contains no citations, removing the empty slide.
  • Site-Wide Verification: Audited all 9 rendered revealjs decks (algebra, calculus, index, linear-algebra, measures, notation, proof-writing, sets-functions, and vector-calculus) to verify zero empty or title-only slides remain across the site. All cross-references, anchors, and includes verified clean.

@dem-extra1
dem-extra1 marked this pull request as ready for review September 30, 2026 21:28
@dem-extra1 dem-extra1 changed the title fix: remove empty slide at Derivatives heading in calculus deck fix: remove empty and title-only slides across revealjs decks (closes #16) Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Confirmed: 7 files changed, matching gh pr view's file list exactly, and none touch .gitmodules or the latex-macros submodule pointer.

This PR is small, well-scoped, and I verified its core claim directly against the live production site: each of the five "empty/title-only slide" bugs it targets (calculus, linear-algebra, algebra, notation, proof-writing) is real and reproducible in the current deployed HTML, and the fix — reordering content so it lands after rather than before the relevant ## heading, confirmed against the slidebreak.lua and revealjs-level1-slide-breaks.lua filter logic — addresses each one without altering any #id anchors, page paths, or citation behavior. The three untouched decks with similar macros.qmd-then-heading structure (sets-functions, measures, vector-calculus) were correctly left alone, since their preamble content is non-empty (a ::: remark block or lead-in paragraph), so the PR's claim of a full site audit holds up. The index.qmd documentation table update accurately reflects the new file list of self-including-macros fragments. No .qmd syntax breakage, no build-artifact commits, no bibliography/lint concerns, and nothing that reads as AI-hallucinated (all referenced files, paths, and shortcodes exist in the repo).

No blocking or non-blocking issues found.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "d32bd2aed4a95eeda423b1ed9c31ad6f64f4e642",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Verified against production HTML that each targeted empty-slide bug in calculus.qmd, linear-algebra.qmd, _algebra.qmd, _notation.qmd, and proof-writing.qmd is real, and the reordering fix resolves it without touching any heading id or anchor.",
  "holistic_assessment": "Scope stays limited to the stated slide-rendering bug, index.qmd documentation table was updated to match, and the three untouched decks were correctly left alone since their preamble content is non-empty."
}

Reviewed commit: d32bd2a

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.8190 (review) — run

@dem-extra1
dem-extra1 merged commit d2a7be1 into main Sep 30, 2026
22 checks passed
@dem-extra1
dem-extra1 deleted the fix/empty-slide-derivatives branch September 30, 2026 21:36
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-30 14:44 PDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty slide at the "Derivatives" heading in the calculus deck

1 participant