fix(kimi-web): make ask-user question card scrollable on mobile#1388
fix(kimi-web): make ask-user question card scrollable on mobile#1388mikkelchokolate wants to merge 1 commit into
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f98782b0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .qbody { | ||
| min-height: 0; | ||
| overflow-y: auto; | ||
| -webkit-overflow-scrolling: touch; |
There was a problem hiding this comment.
For long questions on mobile, this does not actually make the card body scroll because Card.vue wraps the default slot in .ui-card__body, which is the flex item under .qcard; .qbody itself has no constrained height, while the root card keeps overflow: hidden. The options can still expand past the max-height and leave the footer clipped/unreachable. Put the min-height: 0/overflow-y: auto behavior on the generated .ui-card__body (or otherwise make that wrapper the constrained flex child).
Useful? React with 👍 / 👎.
mikkelchokolate
force-pushed
the
fix/mobile-question-scroll
branch
from
1f98782 to
fd932ee
Compare
|
@codex review |
|
@chatgpt-codex-connector please re-review the latest commit. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd932eea05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,108 @@ | |||
| // @vitest-environment jsdom | |||
There was a problem hiding this comment.
The scoped apps/kimi-web/AGENTS.md says this package's test command is for “pure logic tests only; no jsdom / component tests.” This new test opts into jsdom and mounts an SFC with @vue/test-utils, so every pnpm --filter @moonshot-ai/kimi-web test run now includes the browser/component test path that the package rules explicitly exclude; move this coverage to an approved visual/browser path or a pure logic/style check instead.
Useful? React with 👍 / 👎.
mikkelchokolate
force-pushed
the
fix/mobile-question-scroll
branch
from
fd932ee to
5cb2506
Compare
|
@chatgpt-codex-connector rereview please. Removed the jsdom component test and reverted package.json/pnpm-lock changes per the package AGENTS.md. The PR now contains only the CSS fix in QuestionCard.vue. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
On mobile the app shell disables document scrolling, and the bottom dock (ChatDock) has no max-height or overflow. A question card with many/long options could grow past the viewport, making the Submit button unreachable.
This change constrains QuestionCard on narrow viewports (<=640px) to a flex column with a capped height, and makes .ui-card__body scrollable while the header/footer stay pinned.
Fixes #1400