test: guard against wallet/mobile/agent registry drifttest: guard aga…

[Jessicaayegh]

Summary

Added three-way asset registry parity coverage for wallet, mobile, and agent registries.

The agent now resolves registered assets through its registry, validates all issuers with StrKey, and reports diverging codes or issuers clearly. Offline Jest tests pass.

Related issue

Closes #822

Type of change

• Bug fix
• New feature
• Refactor
• Docs
• Tests
• CI / tooling

Component

• Wallet frontend
• SDK
• Contracts
• Agent

Checklist

• I have read CONTRIBUTING.md
• cargo test passes (contracts)
• npm run typecheck passes (wallet / sdk / agent)
• npm run build passes (wallet / agent)
• I added or updated tests where relevant
• I updated docs / README where relevant

Screenshots / test output

No UI changes.

• Mobile registry parity test: 2 tests passed
• Agent registry wiring test: 2 tests passed
• Tests run offline with no network calls.
• Mobile typecheck remains blocked by pre-existing missing dependencies:
  @react-navigation/bottom-tabs and @noble/curves/p256.js.

[drips-wave]

@Jessicaayegh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[vercel]

@Jessicaayegh is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

[Miracle656]

The deliverable for #822 is good — frontend/mobile/lib/__tests__/assetRegistryParity.test.ts compares wallet, mobile and agent by issuer, runs StrKey.isValidEd25519PublicKey over every entry, names the diverging entry in the failure message, and touches no network. That's the test we wanted. The problem is everything else that came with it.

Blocker: merging this breaks every CI run on main.

I test-merged the head onto main and .github/workflows/ci.yml comes out with the verify-lockfiles: job declared twice — line 43 (already on main from #868) and line 59 (added again by commit 90f4d46 here). GitHub Actions rejects a workflow with a duplicate job key outright, so nothing on main would run at all.

That duplicate is a symptom. The branch carries nine commits, and only the first (def231c) is the parity test. The other eight re-apply CI work that has since landed on main:

• 90f4d46 fix(ci): apply missing lockfile verification infrastructure from commit 47… — this is #823/#868, merged as 1e8bc7c, which is your own base commit.
• 634ae87, 9da4179, 78babb7, e1438d4, 435d0be — mobile E2E reliability, Android SDK pinning, npm ci warning fallbacks across seven workflow files.
• 53c082f reverts frontend/mobile/lib/passkeyLogin.ts from @noble/curves/p256.js back to @noble/curves/p256, dropping the explicit .js extension that ESM resolution on main needs.

The PR title is corrupted the same way — test: guard against wallet/mobile/agent registry drifttest: guard aga… — which is the other tell that a merge went sideways here.

What to do: rebase onto current main and keep only the registry-parity work. Concretely that's frontend/mobile/lib/__tests__/assetRegistryParity.test.ts, packages/agent/src/assets.ts, and the packages/agent/src/network.ts / price.ts changes that read the issuer from ASSET_REGISTRY instead of a literal — those last two are genuinely in scope and I'd like to keep them. Drop all seven .github/workflows/* files, scripts/verify-all-lockfiles.mjs, scripts/tests/verify-all-lockfiles.test.mjs, package.json, frontend/mobile/package.json, frontend/mobile/package-lock.json, frontend/mobile/lib/passkeyLogin.ts and its test. If the CI reliability work is worth keeping on its own, it should be a separate PR against current main — it can't ride along here. Also fix the title.

Two smaller things once that's done:

1. packages/agent/src/assets.ts line 42 pastes sacContractId: 'CBSJZEIO5C7KC2SF3MKSNXXJSW5G3VTNBX4ATMKUI3B2MR4JKM4R26YF'. I validated it — it is the correct SAC — but #822's ground rules ask for it to be derived, not pasted. new Asset('USDT0', USDT0_MAINNET_ISSUER).contractId(Networks.PUBLIC) gives the same string and stays correct if anything upstream ever changes. Either derive it, or assert the derivation matches the literal in the parity test.

2. packages/agent/src/assets.ts also collides with #935, which creates a file at the same path. Whichever lands second will need a rebase; heads-up so it isn't a surprise.

The parity test itself needs no changes. Please keep it exactly as it is.

[Miracle656]

Re-reviewed at 5a88e723. The rebase is exactly right — one commit, five files, and every single thing I asked you to drop is gone: all seven workflow files, scripts/verify-all-lockfiles.mjs and its test, both package.jsons, the mobile lockfile, and passkeyLogin.ts. The duplicate verify-lockfiles: job that would have broken every CI run on main is gone with them. That was the blocker and it is fully resolved.

The SAC is derived now too:

sac: new Asset('USDT0', USDT0_MAINNET_ISSUER).contractId(Networks.PUBLIC),

That was my point 1 and it's done properly.

Two things are still in the way, and one of them is more serious than it looks.

1. network.ts importing assets.ts creates a module-initialisation cycle

This is why Wallet frontend — typecheck & build is failing:

ReferenceError: Cannot access 'L' before initialization
Error: Failed to collect page data for /api/agent

The cycle is:

• assets.ts:2 — import { NETWORK, USDC_ISSUER } from './network.js'
• network.ts:2 — import { registeredAsset } from './assets.js'

and critically, network.ts calls registeredAsset(...) at module scope, inside DEFAULTS. registeredAsset reads REGISTRY, which assets.ts builds at module scope using USDC_ISSUER from network.ts. Whichever module the bundler evaluates first sees the other's binding in its temporal dead zone, and the wallet build dies collecting /api/agent.

It also doesn't buy anything, which is the part I'd most like you to see:

usdcIssuer: registeredAsset('USDC', 'mainnet')?.issuer ?? 'GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN',

The literal is still there as the fallback. So the duplication the change was meant to remove is still present, and a cycle has been added to keep it company. Please revert packages/agent/src/network.ts to main.

price.ts is fine and I'd like to keep it — it calls registeredAsset inside a function rather than at module scope, so it creates no cycle.

2. The parity test imports an export that doesn't exist

lib/__tests__/assetRegistryParity.test.ts(3,10): error TS2305:
  Module '"../../../../packages/agent/src/assets"' has no exported member 'ASSET_REGISTRY'.
lib/__tests__/assetRegistryParity.test.ts(40,42): error TS18046: 'asset' is of type 'unknown'.

packages/agent/src/assets.ts has const REGISTRY — not exported, and not the same shape as the other two. Wallet and mobile export ASSET_REGISTRY as a flat Record<code, asset>; the agent's is nested Record<network, Record<code, asset>>. So Object.entries(agentRegistry) would hand you ['mainnet', {...}], and asset.issuer would be undefined even if the import resolved. The two unknown errors are downstream of the failed import.

The agent already exports the right thing for this, and it exists for exactly this reason — read its doc comment:

export const ALL_REGISTERED_ASSETS: ReadonlyArray<{ network: StellarNetwork; asset: VerifiedAsset }>

Comparing against that, filtered to network === 'mainnet', gives you the agent side without exporting REGISTRY and without flattening anything by hand.

3. The title is still corrupted

test: guard against wallet/mobile/agent registry drifttest: guard aga… — I'll fix this at squash-merge if you'd rather not force-push for it alone, but it's worth fixing in the PR so the commit message is right.

Still true

The parity test itself is the deliverable and I still want it as-is in substance — comparing by issuer, StrKey over every entry, naming the diverging entry, no network. Fix the import so it compiles against the agent's real export, revert network.ts, and this goes in.

One heads-up from last time that still stands: packages/agent/src/assets.ts collides with #935, which creates a file at the same path. Whichever lands second needs a rebase.