fix(lwtr): record the event name passed to record_event - #11
Merged
Conversation
tx_handle::record_event and record_event_at_time took the event name as their first parameter but never used it: the event transaction was begun with an empty value() and the ".events" generator was constructed without a begin attribute name, so every event written through this API ended up anonymous in the trace. The shipped examples clearly expect the names (pipeline stages "IF", "ID", ...) to be recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tx_handle::record_event and record_event_at_time took the event name as their first parameter but never used it: the event transaction was begun with an empty value() and the ".events" generator was constructed without a begin attribute name, so every event written through this API ended up anonymous in the trace.
The shipped examples clearly expect the names (pipeline stages "IF", "ID", ...) to be recorded.
And logically each event should at least have name and timestamp.