Repository navigation
perf(wallet): memoize wallet connection display computations - #1281
Merged
nanaf6203-bit merged 1 commit intoOct 15, 2026
Merged
nanaf6203-bit merged 1 commit into
nanaf6203-bit merged 1 commit into
Conversation
|
@Gracora Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memoizes the derived display values computed inside the WalletConnection connected view so the truncated address and formatted balance are only recalculated when the underlying address or balance actually changes. This removes repeated string formatting from renders caused by unrelated wallet or chain state updates.
Problem
WalletConnectedView recomputed ormatAddress(address) and ormatBalanceForDisplay(balance) on every render. Because the view re-renders on wallet store and chain awareness updates, those formatting helpers ran far more often than their inputs changed, adding avoidable work to a component that sits in the page header.
Changes Made
Implementation Details
Both formatting helpers are now invoked together inside one memoization block, so a render triggered by an unrelated store field keeps the previous strings instead of reformatting them. The existing useCallback for the disconnect handler and the React.memo wrapper on the view were left unchanged.
Closes #1170
Closes #1169
Closes #1168
Closes #1167