Repository navigation
feat(wallet): add error boundary around wallet connector - #1280
Merged
nanaf6203-bit merged 1 commit intoOct 15, 2026
Merged
Conversation
|
@Magrexy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an error boundary around the WalletConnection component so an unexpected render failure in the wallet status UI degrades into a friendly, retryable fallback instead of unmounting the header that hosts it. This keeps the surrounding page usable when wallet state or a browser wallet provider misbehaves.
Problem
WalletConnector renders the connected and disconnected wallet views directly with no error boundary. Any exception thrown while rendering those views propagates upward and takes the whole layout down with it, leaving users without wallet controls and with no way to recover short of reloading the page.
Changes Made
Implementation Details
The existing ErrorBoundary already supplies a fallback panel with a "Try Again" button that resets its internal hasError state, so no new error handling code was introduced. Since ErrorBoundary is a client component, it composes cleanly inside the client-side WalletConnector, and the boundary sits high enough to catch failures from either view without altering their props.
Closes #1158
Closes #1157
Closes #1156
Closes #1155