Fix umdp lower and camel case checking#219
Open
Pierre Siddall (Pierre-siddall) wants to merge 5 commits intoMetOffice:mainfrom
Open
Fix umdp lower and camel case checking#219Pierre Siddall (Pierre-siddall) wants to merge 5 commits intoMetOffice:mainfrom
Pierre Siddall (Pierre-siddall) wants to merge 5 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: R Sharp (@r-sharp)
This PR fixes the umdp3 checker to correctly identify non lowercase and CamelCase variable names and subsequently output the correct number of failures in the script.
closes #214
Code Quality Checklist
Testing
Tested on a UM source file and changed two variable names to upper case and changed one lowercase variable name to CamelCase. umdp3_conformance.py reported a failure in the appropriate file containing two errors as expected.
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review