fix: forward run<T> from a flow sub-router to its host#56
Merged
Conversation
Inside a flow, context.router<R>() resolves to the flow's sub-router; run on it added the nested flow to a list nothing renders — the flow never appeared and its future never completed. Sub-routers now carry a host pointer and forward run to the root, so nested flows always land on the rendered overlay stack. Cuts kaisel_core 1.0.1.
Contributor
|
📖 Docs preview: https://kaisel.dev/pr-56/ (updates on every push; removed when this PR closes) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2319 2322 +3
=========================================
+ Hits 2319 2322 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55