Repository navigation
commit fix to prevent nan coefficients from propagating into valid contrasts - #294
Merged
Merged
Conversation
lucas-diedrich
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
In the current implementation, when the contrast matrix C is multiplied with B_cond, a NaN coefficient caused every contrast of the feature to go to NaN, even in features where the other conditions are fully observed. This goes back to the matrix multiplication, where operations like (1 * 20.1) + (-1 * 22.5) + (0 * NaN) would set 0 * NaN = NaN, and subsequently 20.1 - 22.5 + NaN = NaN. What should happen is (1 * 20.1) + (-1 * 22.5) + (0 * NaN) = 20.1 - 22.5, which is now the case by zero-filling the nan coefficients and setting the respective contrasts back to nan later.