Skip to content

[API] Fix PMAD return signature - #275

Merged
lucas-diedrich merged 8 commits into
mainfrom
fix/api-consistency_metrics-II
Sep 7, 2026
Merged

lucas-diedrich merged 8 commits into
mainfrom
fix/api-consistency_metrics-II

Conversation

@lucas-diedrich

@lucas-diedrich lucas-diedrich commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

PMAD + PCV returned dataframe independent of inplace parameter

@lucas-diedrich lucas-diedrich self-assigned this Sep 3, 2026
@lucas-diedrich lucas-diedrich added the bug Something isn't working label Sep 3, 2026

@vbrennsteiner vbrennsteiner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-diedrich lucas-diedrich added the breaking-change Breaking change that changes the API label Sep 3, 2026
@lucas-diedrich
lucas-diedrich merged commit f5c24bc into main Sep 7, 2026
14 checks passed
@lucas-diedrich
lucas-diedrich deleted the fix/api-consistency_metrics-II branch September 7, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaking change that changes the API bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants