Skip to content

renumber headers in study notebook 04 - #249

Merged
vbrennsteiner merged 6 commits into
mainfrom
harmonize_study_04
Sep 3, 2026
Merged

vbrennsteiner merged 6 commits into
mainfrom
harmonize_study_04

Conversation

@vbrennsteiner

Copy link
Copy Markdown
Collaborator

Purpose of this PR

To harmonize the header and subheader structure across all studies, this PR adjusts them in the 04 scDVP notebook according to notebooks 01 and 02. The goal is to have a (reasonably) uniform structure along the lines of Background - References - Analysis - Summary in all studies.

…d - References - Analysis - Summary pattern of notebooks 01 and 02
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.92%. Comparing base (ca7b133) to head (9c06e51).
⚠️ Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   73.19%   73.92%   +0.72%     
==========================================
  Files          35       36       +1     
  Lines        2067     2140      +73     
==========================================
+ Hits         1513     1582      +69     
- Misses        554      558       +4     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucas-diedrich lucas-diedrich added the documentation Improvements or additions to documentation label Aug 24, 2026

@shanibmo shanibmo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for missing your PR and opening another :)

@lucas-diedrich

lucas-diedrich commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

@vbrennsteiner @shanibmo which one is more up-to-date?

@vbrennsteiner

Copy link
Copy Markdown
Collaborator Author

@vbrennsteiner @shanibmo which one is more up-to-date?

should be this one, I'll transfer the fixes from the other one (typos etc) and merge 👍

Follow-up cleanup on the header harmonization, addressing defects found
while reconciling this PR with the duplicate #253:

- Re-nest "Detailed sanity checks", "CV Analysis" and "Dimensionality
  Reduction" under "6. Biological validation and quality assessment",
  which previously had a single orphan subsection. Sections now run 1-9.
- Fix the three duplicate "11.3" headers in the TF section (now 8.1-8.8).
- Collapse the split "10. Recreating Study Figures:" header, whose title
  remainder had been stranded as body text.
- Normalize subsection numbering to the dotted N.M. form used elsewhere
  in the notebook and in study 05.
- Fix 27 typos, including the seven Copilot flagged on #253.
- Set kernel display_name to "alphapept", matching studies 01-03.

Markdown and notebook metadata only; no cells were re-executed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vbrennsteiner
vbrennsteiner merged commit 9639651 into main Sep 3, 2026
14 checks passed
@vbrennsteiner
vbrennsteiner deleted the harmonize_study_04 branch September 3, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants