fix(ci): 2 remaining unused TS imports + browser-use 1.1.2 + db.test rolling date#244
Open
erudenko wants to merge 1 commit into
Open
fix(ci): 2 remaining unused TS imports + browser-use 1.1.2 + db.test rolling date#244erudenko wants to merge 1 commit into
erudenko wants to merge 1 commit into
Conversation
…dates in db.test Fixes remaining failures on fix/ci-workflow-trigger-broadening (runs 26430494516 / 26430492914). The 2026-05-26 commit to that branch fixed rolling dates in integration.test.ts and removeGitignoreEntries in conventions-integration.test.ts but left three issues: 1. doctor.test.ts imports `vi` from vitest but never calls it — TS6133 2. conventions-manager.ts imports `existsSync` from node:fs but never uses it — TS6133 (readFileOrEmpty catches ENOENT; stat comes from node:fs/promises) 3. marketplace.json still shows browser-use@1.1.1 while plugin.json is at 1.1.2 — causes marketplace-sync integration test to fail once the TS check is fixed Also fixes a time-bomb in db.test.ts: the deleteOldSessions "recent session" test used the hardcoded date "2026-03-26" (now 64 days old, within 90-day window today but will cross the threshold around 2026-06-24 and break the test). Replaced with TODAY constant.
This was referenced May 29, 2026
Open
CI/CD audit (2026-05-23): latest runs green, but 10+ fix PRs are unmerged and blocking progress
#223
Open
Open
This was referenced Jun 6, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
CI runs 26430494516 and 26430492914 on PR #32 (
fix/ci-workflow-trigger-broadening).The 2026-05-26 commit to that branch fixed rolling dates in
integration.test.tsand removed theremoveGitignoreEntriesunused import fromconventions-integration.test.ts, but left two more TS6133 errors — sotest (22)(the Node 22 matrix job runningpnpm typecheck) still fails.Once the TS check was unblocked, the next failure would be the
marketplace-syncintegration test catching a version drift.Root causes fixed
1. TS6133 — unused
viimport indoctor.test.tstools/claudeup-core/src/__tests__/unit/doctor.test.tsimportedvifromvitestbut no test in the file callsvi.mock(),vi.fn(), orvi.spyOn().tsc --noEmitwithnoUnusedLocalsflags it as TS6133.Fix: Removed
vifrom the vitest import line.2. TS6133 — unused
existsSyncimport inconventions-manager.tstools/claudeup-core/src/services/conventions-manager.tsimportedexistsSyncfromnode:fsbut the function body usesreadFileOrEmpty(which catches ENOENT internally) andstatfromnode:fs/promises—existsSyncis never called.Fix: Removed the
import { existsSync } from 'node:fs'line entirely.3.
browser-useversion mismatch (marketplace-sync)plugins/browser-use/plugin.jsonis at1.1.2but.claude-plugin/marketplace.jsonstill showed1.1.1. Themarketplace-syncintegration test catches exactly this drift and would fail as the next error after the TS check was fixed.Fix: Bumped
browser-useto1.1.2and updated the description to matchplugin.json.4. Time-bomb in
db.test.tsdeleteOldSessionstest (proactive)plugins/stats/tests/db.test.tsused the hardcoded date"2026-03-26"as the "recent" session in thedeleteOldSessionsretention test. As of 2026-05-29 that date is 64 days old — within the 90-day window so the test currently passes. But around 2026-06-24 it crosses the threshold, the "recent" session gets deleted, anddeletedCountbecomes 2 instead of 1.Fix: Added a module-level
const TODAYconstant and replaced the hardcoded date withTODAY— same pattern already inintegration.test.ts.Files changed
tools/claudeup-core/src/__tests__/unit/doctor.test.tsvifrom vitest importtools/claudeup-core/src/services/conventions-manager.tsexistsSyncfrom node:fs import.claude-plugin/marketplace.jsonbrowser-useversion1.1.1→1.1.2, description updatedplugins/stats/tests/db.test.tsTODAYconstant; useTODAYindeleteOldSessionsrecent-session testRelationship to other PRs
fix/ci-workflow-trigger-broadening) — this PR is stacked directly on its head. If fix(ci): remove hardcoded branch filters from workflow triggers #32 is merged first, re-target tofix/ci-type-errors-and-stale-test-date.fix/ci-26430492914) — covers the same root causes but on a different branch stack. Both are green fixes; whichever is merged first resolves the debt.fix/ci-24307096245) — comprehensive fix, all 13 checks green since 2026-05-15. Also resolves these root causes.Generated by Claude Code