Skip to content

fix: remove duplicate Ktor JSON configuration in HttpClient setup #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorentinPosch merged 1 commit into from
May 7, 2026
Merged

fix: remove duplicate Ktor JSON configuration in HttpClient setup #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions shared/src/androidMain/kotlin/io/redlink/more/services/network/HttpClientReceiver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,15 @@ package io.redlink.more.services.network

import io.ktor.client.HttpClient
import io.ktor.client.engine.android.Android
import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
import io.ktor.client.plugins.defaultRequest
import io.ktor.client.plugins.logging.LogLevel
import io.ktor.client.plugins.logging.Logger
import io.ktor.client.plugins.logging.Logging
import io.ktor.http.ContentType
import io.ktor.http.HttpHeaders
import io.ktor.http.contentType
import io.ktor.serialization.kotlinx.json.json

actual fun getHttpClient(customLogger: Logger): HttpClient = HttpClient(Android) {
install(ContentNegotiation) {
json()
}

defaultRequest {
contentType(ContentType.Application.Json)
Expand Down
5 changes: 0 additions & 5 deletions shared/src/iosMain/kotlin/io/redlink/more/services/network/HttpClientReceiver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,15 @@ package io.redlink.more.services.network
import io.ktor.client.HttpClient
import io.ktor.client.engine.darwin.Darwin
import io.ktor.client.plugins.auth.Auth
import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
import io.ktor.client.plugins.defaultRequest
import io.ktor.client.plugins.logging.LogLevel
import io.ktor.client.plugins.logging.Logger
import io.ktor.client.plugins.logging.Logging
import io.ktor.http.ContentType
import io.ktor.http.HttpHeaders
import io.ktor.http.contentType
import io.ktor.serialization.kotlinx.json.json

actual fun getHttpClient(customLogger: Logger): HttpClient = HttpClient(Darwin) {
install(ContentNegotiation) {
json()
}

defaultRequest {
contentType(ContentType.Application.Json)
Expand Down
Loading