fix(ci): bump smoke-test MCP v2 pin to 2.0.0-beta.4 - #3349
Conversation
The packed-package smoke test asserts an exact pin of the
@modelcontextprotocol/{client,node,server} packages, but the constant
was left at 2.0.0-alpha.2 after the SDK/CLI/inspector deps were bumped
to 2.0.0-beta.4. The assertion fires on the first spec it reads and
fails the "Smoke packed npm packages" job.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_bccd89bf-a6c5-4077-a5cd-d24f613bd22b) |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdates the smoke test’s expected MCP v2 package version from Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The
Smoke packed npm packagesCI job hardcodes an exact expected version for the MCP v2 packages:readExpectedMcpV2Versions()throws if any publishable package's pin for@modelcontextprotocol/{client,node,server}isn't exactly that string. The SDK/CLI/inspector deps were since bumped to2.0.0-beta.4, so the assertion fires on the first spec it reads:Fix
Bump the constant to
2.0.0-beta.4to match the actual pins. Verified all three packages (client/node/server) acrosssdk,cli, andmcpjam-inspectorresolve uniformly to2.0.0-beta.4.Note
This guard is deliberately strict (exact pin, lockstep across all packages), so every MCP v2 bump must also touch this constant. If bumps stay frequent, worth deriving the expected version from the SDK's
package.jsoninstead of hardcoding — left out of this fix to keep it minimal.🤖 Generated with Claude Code
Note
Low Risk
Single constant change in a CI smoke script; no runtime or production code paths affected.
Overview
Updates the Smoke packed npm packages CI script so its hardcoded MCP v2 version matches the repo’s exact pins on
@modelcontextprotocol/client,node, andserver.expectedMcpV2PackageVersionmoves from2.0.0-alpha.2to2.0.0-beta.4, aligning withsdk,cli, andmcpjam-inspectorand stoppingreadExpectedMcpV2Versions()from failing when it compares workspacepackage.jsonspecs to the stale constant.Reviewed by Cursor Bugbot for commit 3fb213a. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Update the smoke test’s expected MCP v2 version to 2.0.0-beta.4 (from 2.0.0-alpha.2) for
@modelcontextprotocol/{client,node,server}, matching current pins insdk,cli, andmcpjam-inspectorand fixing the failingSmoke packed npm packagesCI job.Written for commit 3fb213a. Summary will update on new commits.