Skip to content

fix(ci): bump smoke-test MCP v2 pin to 2.0.0-beta.4 - #3349

Merged
chelojimenez merged 1 commit into
mainfrom
fix/smoke-mcp-v2-beta4-pin
Jul 21, 2026
Merged

fix(ci): bump smoke-test MCP v2 pin to 2.0.0-beta.4#3349
chelojimenez merged 1 commit into
mainfrom
fix/smoke-mcp-v2-beta4-pin

Conversation

@chelojimenez

@chelojimenez chelojimenez commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What

The Smoke packed npm packages CI job hardcodes an exact expected version for the MCP v2 packages:

// .github/scripts/smoke-packed-npm-packages.mjs
const expectedMcpV2PackageVersion = "2.0.0-alpha.2";

readExpectedMcpV2Versions() throws if any publishable package's pin for @modelcontextprotocol/{client,node,server} isn't exactly that string. The SDK/CLI/inspector deps were since bumped to 2.0.0-beta.4, so the assertion fires on the first spec it reads:

Error: @mcpjam/sdk must pin @modelcontextprotocol/client to 2.0.0-alpha.2, got "2.0.0-beta.4".

Fix

Bump the constant to 2.0.0-beta.4 to match the actual pins. Verified all three packages (client/node/server) across sdk, cli, and mcpjam-inspector resolve uniformly to 2.0.0-beta.4.

Note

This guard is deliberately strict (exact pin, lockstep across all packages), so every MCP v2 bump must also touch this constant. If bumps stay frequent, worth deriving the expected version from the SDK's package.json instead of hardcoding — left out of this fix to keep it minimal.

🤖 Generated with Claude Code


Note

Low Risk
Single constant change in a CI smoke script; no runtime or production code paths affected.

Overview
Updates the Smoke packed npm packages CI script so its hardcoded MCP v2 version matches the repo’s exact pins on @modelcontextprotocol/client, node, and server.

expectedMcpV2PackageVersion moves from 2.0.0-alpha.2 to 2.0.0-beta.4, aligning with sdk, cli, and mcpjam-inspector and stopping readExpectedMcpV2Versions() from failing when it compares workspace package.json specs to the stale constant.

Reviewed by Cursor Bugbot for commit 3fb213a. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Update the smoke test’s expected MCP v2 version to 2.0.0-beta.4 (from 2.0.0-alpha.2) for @modelcontextprotocol/{client,node,server}, matching current pins in sdk, cli, and mcpjam-inspector and fixing the failing Smoke packed npm packages CI job.

Written for commit 3fb213a. Summary will update on new commits.

Review in cubic

The packed-package smoke test asserts an exact pin of the
@modelcontextprotocol/{client,node,server} packages, but the constant
was left at 2.0.0-alpha.2 after the SDK/CLI/inspector deps were bumped
to 2.0.0-beta.4. The assertion fires on the first spec it reads and
fails the "Smoke packed npm packages" job.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 21, 2026
@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_bccd89bf-a6c5-4077-a5cd-d24f613bd22b)

@chelojimenez

Copy link
Copy Markdown
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@chelojimenez
chelojimenez merged commit 61cd24e into main Jul 21, 2026
12 of 13 checks passed
@chelojimenez
chelojimenez deleted the fix/smoke-mcp-v2-beta4-pin branch July 21, 2026 07:42
@github-actions

Copy link
Copy Markdown
Contributor

Internal preview

Preview URL will appear in Railway after the deploy finishes.
Deployed commit: 20d6b92
PR head commit: 3fb213a
Backend target: staging fallback.
Access is employee-only in non-production environments.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a814cc7a-58ca-45da-b20c-18af4ed2eb57

📥 Commits

Reviewing files that changed from the base of the PR and between 26ef873 and 3fb213a.

📒 Files selected for processing (1)
  • .github/scripts/smoke-packed-npm-packages.mjs

Walkthrough

Updates the smoke test’s expected MCP v2 package version from 2.0.0-alpha.2 to 2.0.0-beta.4 for package manifest dependency validation.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant