feat: differentiate DNS guidance by hosting mode, remove DIY DNS record creation#57
Merged
Merged
Conversation
…rd creation When DNS hosting is enabled, the server creates the DNS zone and records automatically when DnsHostingEnabled is set. The CLI no longer duplicates this work by calling CreateZone/CreateRecord. Wizard changes: - Remove dnsService from WebsitesWizard (server handles DNS setup) - Replace executeDNSSetup with NS delegation instructions only - Managed DNS validation retries with exponential backoff (5 attempts, 2s-15s) with spinner, since server creates records asynchronously - On retry exhaustion, explain NS propagation delay + validate command - State-aware completion message (not 'validated' when validation failed) - Remove redundant DNS/vvalidation output after wizard completes Non-wizard changes: - Add showDNSHostingInstructions/showSelfManagedDNSInstructions split - Add getNameservers to fetch NS records from API - Move 'Then validate' hint to non-wizard call sites only - Update ipfs-sdk to v0.1.43
This comment has been minimized.
This comment has been minimized.
Code Coverage ReportTotal Coverage: 35.0% Generated from commit: 34f7eb5 |
vr == nil || !vr.Valid entered the true branch then dereferenced vr.Message on a nil pointer. Split into separate nil check and validity check to prevent panic.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DNS hosting is enabled, the server creates the DNS zone and records
automatically when DnsHostingEnabled is set. The CLI no longer duplicates
this work by calling CreateZone/CreateRecord.
Wizard changes:
2s-15s) with spinner, since server creates records asynchronously
Non-wizard changes:
This PR differentiates DNS setup guidance based on the website's hosting mode and removes the client-side automatic DNS record creation, which is now handled server-side.
Key changes:
Differentiated DNS instructions by hosting mode: When DNS hosting is enabled (Pinner-managed), the CLI now shows NS delegation instructions telling users to update their domain's nameservers at their registrar. For self-managed DNS, it continues showing the TXT verification and dnslink CNAME records users must add manually.
Removed client-side DNS zone/record creation: The
setupDNSHostingfunction andDNSServicedependency have been removed from the wizard and CLI commands (websites create,websites update). The server now automatically creates DNS zones and records when a website is created withDnsHostingEnabled=true, so the client no longer needs to make those API calls.Managed DNS validation with retry: The wizard's validation step now uses exponential backoff retries (5 attempts) with a spinner for managed DNS, since the server creates DNS records asynchronously and propagation takes time. Self-managed DNS validation continues to prompt the user to add records first.
Enhanced
websites configoutput: Now displays nameservers alongside the gateway domain, and shows both CNAME and NS record tables when applicable.Updated
websites validateoutput: Therequired_recordsJSON output and CLI instructions now reflect the hosting mode — NS records for managed DNS, TXT/CNAME records for self-managed DNS.