fix: detect 401/403 auth errors from boxo pinning client#49
Merged
Conversation
Boxo returns HTTP errors as raw strings like 'remote pinning service returned http error 401: ...' which were being wrapped as ErrPinningFailed, producing unhelpful 'pinning failed' messages instead of clear auth errors. Add isBoxoAuthError() with regex matching on boxo error messages and use wrapPinningError/WrapAuthError consistently across Pin, List, UnpinAll, UpdateMetadata, and waitForPinCompletion.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Coverage ReportTotal Coverage: 34.6% Generated from commit: 6f5029f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boxo returns HTTP errors as raw strings like 'remote pinning service
returned http error 401: ...' which were being wrapped as ErrPinningFailed,
producing unhelpful 'pinning failed' messages instead of clear auth errors.
Add isBoxoAuthError() with regex matching on boxo error messages and
use wrapPinningError/WrapAuthError consistently across Pin, List, UnpinAll,
UpdateMetadata, and waitForPinCompletion.
Detect and properly handle 401/403 authentication errors from the boxo pinning client
The boxo remote pinning client returns HTTP 401/403 errors as string-based error messages (e.g., "remote pinning service returned http error 401: unauthorized") rather than typed errors, causing them to be misidentified as generic pinning failures. This PR adds detection for these auth errors via regex matching on the error message, and ensures all pinning operations (Pin, List, Status, UpdateMetadata, waitForPinCompletion) properly surface them as authentication errors with a clear message directing users to re-authenticate.