Skip to content

feat(infobox): collapsible team history display#7834

Open
ElectricalBoy wants to merge 4 commits into
mainfrom
collapse-team-history-chevron-toggle
Open

feat(infobox): collapsible team history display#7834
ElectricalBoy wants to merge 4 commits into
mainfrom
collapse-team-history-chevron-toggle

Conversation

@ElectricalBoy

@ElectricalBoy ElectricalBoy commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Inspired by #7831

This PR makes the team history displays on player infoboxes collapsible.

How did you test this change?

preview with dev

collapsed:
image
expanded:
image

@mbergen

mbergen commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Would it make sense to have it show the latest ~5 teams, and collapse only additional rows?
Not sure how that works out with the older being at the top, maybe we need to reverse them

@hjpalpha

Copy link
Copy Markdown
Collaborator

we should still discuss this on the main discord
in case some people have strong opinions about it

@ElectricalBoy
ElectricalBoy changed the base branch from collapse-team-history to main July 21, 2026 07:39
@hjpalpha

Copy link
Copy Markdown
Collaborator

Would it make sense to have it show the latest ~5 teams, and collapse only additional rows? Not sure how that works out with the older being at the top, maybe we need to reverse them

i am of the opinion, that we do not need to show any here in uncollapsed form
the current team is already shown in the infobox and anything else is just rarely used i would argue, hence default collapse it^^

@ElectricalBoy ElectricalBoy changed the title feat(infobox): use chevron toggle for collapsing team history feat(infobox): collapsible team history display Jul 21, 2026
@mbergen

mbergen commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Would it make sense to have it show the latest ~5 teams, and collapse only additional rows? Not sure how that works out with the older being at the top, maybe we need to reverse them

i am of the opinion, that we do not need to show any here in uncollapsed form the current team is already shown in the infobox and anything else is just rarely used i would argue, hence default collapse it^^

fwiw, i personally always scroll to the team history, as the current team is somewhat buried inbetween other lines

@hjpalpha

Copy link
Copy Markdown
Collaborator

https://discord.com/channels/93055209017729024/1529031538505678858 for the discussion on discord

@hjpalpha

Copy link
Copy Markdown
Collaborator

Would it make sense to have it show the latest ~5 teams, and collapse only additional rows? Not sure how that works out with the older being at the top, maybe we need to reverse them

i am of the opinion, that we do not need to show any here in uncollapsed form the current team is already shown in the infobox and anything else is just rarely used i would argue, hence default collapse it^^

fwiw, i personally always scroll to the team history, as the current team is somewhat buried inbetween other lines

well implementation of that would be pretty shit i think
especially for the case with manual input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants