Align pyCircuit decode with PTO ISA 0.57.1 - #68
Merged
Conversation
The example Linx pyCircuit cores must recognize the 0.57.1 public tile header contract, where TEPL is the raw Mode/Function carrier and TMA/CUBE families use exact DataType-open masks from the generated ISA projection. Constraint: PTO-ISA/pto-spec b30ed3d is the normative source for 0.57.1 encoding identity Rejected: Keep the old generic BSTART.TMA/BSTART.CUBE masks | they miss TEPL and over-state the 0.57.1 public mnemonic model Confidence: medium Scope-risk: narrow Directive: Keep pyCircuit example decode masks synchronized with the generated Linx ISA projection before changing tile header recognition Tested: python3 contrib/linx/flows/tools/check_pto_isa_v0571_decode.py Tested: python3 -m py_compile contrib/linx/flows/tools/check_pto_isa_v0571_decode.py contrib/linx/designs/examples/linx_cpu_pyc/decode.py contrib/linx/designs/examples/linxcore_inorder/decode.py Tested: git diff --check Not-tested: run_linx_cpu_pyc_cpp.sh/full pyc gates; local worktree lacks pycc and LLVM_DIR/MLIR_DIR or llvm-config-19
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
added 2 commits
July 31, 2026 01:45
Gate the raw TEPL family match with the exact 98-selector PTO ISA 0.57.1 set in both Linx pyCircuit example decoders, and lock that set with a standalone guard. Constraint: The Mode/Function family mask also covers reserved selectors that must remain illegal. Rejected: Decode every family match into the shared tile control path | it silently accepts unassigned operations. Confidence: high Scope-risk: narrow Directive: Update the selector tuple and guard together from the locked PTO operation projection. Tested: PTO decode guard; both example designs elaborated to .pyc; Python compile; git diff --check. Not-tested: C++ and Verilator execution require external toolchains.
The CI pytest console entrypoint did not place the repository root on sys.path, so a main-branch Linx example test could not import the designs namespace. Declare the root in pytest configuration and normalize the PTO 0.57.1 decode files to the repository lint contract. Constraint: CI invokes pytest as a console script and pre-commit over the complete PR diff Rejected: Modify the individual Linx test sys.path | test-local workaround would leave other repository-root imports fragile Confidence: high Scope-risk: narrow Directive: Keep repository-root test imports declarative in pytest configuration Tested: pre-commit on all PR-changed files; pytest tests/unit -m unit (10 passed); PTO ISA 0.57.1 decode guard; py_compile; git diff --check Not-tested: C++ and simulator system lanes; this change only repairs Python CI collection and formatting
14 tasks
zhoubot
marked this pull request as ready for review
August 2, 2026 12:09
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normative source: PTO-ISA/pto-spec commit
2f3f605e289b09d56ef5a9ba39fc80b52948a5f5.Source hashes:
748c1c6ac1bd5482d219cd08b8f0a871c7eda2b8f8afb1e81d498ec742e8abe89705a984e2e48e0d4e856d3fbcfa07041c8578dd326d81f1c90279e826354c32becfbefcc7a31408e5e5293802493f833f68a2fccebb3f9e8008d8b9f4e7658cb9f908deb9cfec412388e95f4532563cf4e462032b43d15996f0f7b4b93b4ec9Verification
git diff --checkThe previous local toolchain gap is covered by the passing GitHub system/toolchain/wheel jobs.
Final merged-source refresh (2026-08-02)