Merged
Conversation
31 tasks
Collaborator
Author
|
I wasn't sure if you wanted every individual solution mapping to be logged too. Should I add that? |
hartig
approved these changes
May 7, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
Looks good!
In the next of these PRs, you can do a handful of exec.operators at a time. Ideally some that are somewhat similar. Additionally, you can do multiple such PRs, then I can go through them whenever I have a bit of time.
| */ | ||
| public class ExecOpBind extends UnaryExecutableOpBaseWithoutBlocking | ||
| { | ||
| private static final Logger logger = LoggerFactory.getLogger( ExecOpBind.class ); |
Member
There was a problem hiding this comment.
I know that the existing example that I showed you uses logger as the name of this variable, but I actually like log more. It is a bit shorter and still clear. Please use that name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works upon #607 by adding logging for
ExecOpBind.