Keep QP info for various cases in ProjectPushDown#603
Open
kentthang010 wants to merge 2 commits intomainfrom
Open
Keep QP info for various cases in ProjectPushDown#603kentthang010 wants to merge 2 commits intomainfrom
kentthang010 wants to merge 2 commits intomainfrom
Conversation
11 tasks
11 tasks
hartig
requested changes
May 5, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
I didn't manage to go through everything, but I added some comments. After addressing them, please revisit the other cases (for which I don't have comments because I didn't manage to look at them) and think about them once more in the light of my comments about the mayReduce flag. Some of them might also be affected by the mayReduce flag (or may be not--just double check).
Collaborator
Author
|
Latest commit resolves the comments above. I also went over the other cases and considered the In summary, the pushdowns that now consider
I don't think I have to check mayReduce for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the
ProjectPushDownpart of #594.