Skip to content

Add MaterializeRDFViewFromRML#601

Merged
hartig merged 6 commits intomainfrom
598-cli-for-executing-rml-mappings
May 4, 2026
Merged

Add MaterializeRDFViewFromRML#601
hartig merged 6 commits intomainfrom
598-cli-for-executing-rml-mappings

Conversation

@kentthang010
Copy link
Copy Markdown
Collaborator

@kentthang010 kentthang010 commented Apr 29, 2026

Closes #598.

Not sure if I should've included sources.json, the hardcoded .json file, I ended up excluding it.

@kentthang010 kentthang010 linked an issue Apr 29, 2026 that may be closed by this pull request
CLI for executing RML mappings #598
Closed
@kentthang010 kentthang010 requested a review from hartig April 29, 2026 10:32
@hartig
Copy link
Copy Markdown
Member

hartig commented Apr 29, 2026

Not sure if I should've included sources.json, the hardcoded .json file, I ended up excluding it.

Please add the file in the examples directory and adapt the code such that it refers to the file there.

hartig
hartig requested changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a few smaller things to be improved.

Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/RunQueryWithoutSrcSel.java
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
@kentthang010
Copy link
Copy Markdown
Collaborator Author

kentthang010 commented Apr 30, 2026

PR comments have been resolved! I also realized I had to change the output flag name to something different (ended up with using outputToFile) as it clashed with the output flag of ModLangOut.

@kentthang010 kentthang010 requested a review from hartig April 30, 2026 08:18
hartig
hartig requested changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment about the helper method was actually meant the other way around, not to create a helper method for setting up the outputStream argument but for performing the actual functionality after the relevant input variables for the functionality have been initialized. So, concretely, create a helper method hat may also be called exec but that takes three arguments: rmlDescr (the Model), baseIRI, and out (the OutputStream).

Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
Comment thread hefquin-cli/src/main/java/se/liu/ida/hefquin/cli/MaterializeRDFViewFromRML.java Outdated
@kentthang010 kentthang010 requested a review from hartig April 30, 2026 12:04
hartig
hartig approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! I will merge it and write another issue about extending the functionality of the tool.

@hartig hartig merged commit 3f10947 into main May 4, 2026
1 check passed
@hartig hartig deleted the 598-cli-for-executing-rml-mappings branch May 4, 2026 19:51
hartig added a commit that referenced this pull request May 4, 2026
@hartig
Mention PR #601 in the CHANGELOG
d059a91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hartig hartig hartig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI for executing RML mappings

2 participants

@kentthang010 @hartig