Merged
Conversation
kentthang010
changed the title
Collaborator
Author
|
As there is some repeated code / logic in some of these cases / operators, I can probably introduce some helper method but I will wait with it for now. Edit: I added it |
hartig
requested changes
Apr 27, 2026
Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
hartig
requested changes
May 3, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
Just one more Javadoc comment and we can merge this PR.
Collaborator
Author
added! |
hartig
approved these changes
May 4, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
Looks good now. I will merge it.
hartig
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for #585.
This PR refactors the
Filteroperator (as suggested in the issue discussion thread).It also introduces early-exit optimizations that set the cardinality to
0withQuality.ACCURATEwhen the input is guaranteed to be empty. This is added for the following operators:LeftJoinUnionDedupMinusProjectBindUnfoldLocalToGlobalGlobalToLocal