Skip to content

[0.19] Implement API for analytics of votes given by a person - #5669

Draft
MrKaplan-lw wants to merge 3 commits into
LemmyNet:release/v0.19from
Fedihosting-Foundation-Forks:vote-analytics-given-by-person
Draft

[0.19] Implement API for analytics of votes given by a person#5669
MrKaplan-lw wants to merge 3 commits into
LemmyNet:release/v0.19from
Fedihosting-Foundation-Forks:vote-analytics-given-by-person

Conversation

@MrKaplan-lw

@MrKaplan-lw MrKaplan-lw commented May 8, 2025

Copy link
Copy Markdown

This contains some rather complex SQL, but it's not possible to simply replicate that with Diesel without losing performance or consistency afaik.

@Nutomic

Nutomic commented May 9, 2025

Copy link
Copy Markdown
Member

Generally new features should be on the main branch, otherwise it will be a lot of hassle to keep bug fixes and enhancements in sync across 0.19 and main.

@MrKaplan-lw

Copy link
Copy Markdown
Author

my development target is currently 0.19, as that is the version we run on lemmy.world.
when the 0.19 PR is acceptable overall I can create an additional PR against main, but it will duplicate my work having to do all those adjustments on two branches before it's ready.
this code is already applied as a patch to lemmy.word with some minor differences, so the 0.19 code doesn't need extra effort for backporting from that.
as this only impements new functionality and doesn't change any existing APIs there should be minimal differences to what would be applied to main anyway.

Comment thread crates/api_common/src/person.rs Outdated
@Nutomic

Nutomic commented May 9, 2025

Copy link
Copy Markdown
Member

Makes sense. Do you also have some tool to visualize the output of this endpoint? If so it would be nice if we could see some example screenshots.

@MrKaplan-lw

MrKaplan-lw commented May 9, 2025

Copy link
Copy Markdown
Author

image

this is what i got so far, i'll see about having post and comment votes in tables next to each other.

Fedihosting-Foundation-Forks/lemmy-ui@5093717...30f0ea6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants