feat: add GQL extension - #38
Merged
Merged
Conversation
- Implements CALL GQL('<query>') as a standalone table function
- Uses ISO GQL ANTLR grammar (from DuckDB GQL extension) for parsing
- Translates GQL to equivalent Cypher via keyword-level transformations
(e.g., INSERT -> CREATE) since GQL and Cypher share common syntax
- Supports MATCH, RETURN, WHERE, ORDER BY, SKIP, LIMIT, path patterns
- Registered as official extension 'GQL'
- MATCH RETURN, MATCH WHERE, path patterns, INSERT→CREATE - Parse error and empty query error handling
- Strip PROPERTY and IF NOT EXISTS keywords (LadybugDB Cypher doesn't support them for CREATE GRAPH) - Fix visitor dispatch by properly delegating visitChildren to base class - Add tests for all CREATE GRAPH variants - GQL INSERT translates to Cypher CREATE as before
When GQL parsing fails, pass the query through as raw Cypher so LadybugDB-specific DDL (CREATE NODE TABLE, CREATE REL TABLE, etc.) works via CALL GQL() without modification. Add test cases for DDL fallback and end-to-end node+rel workflows.
…ors, keyword labels
- basic.test: SHOW_GRAPHS returns (name,type); update 3 expected rows to
include the STANDARD type column (tests 56/57/60)
- basic.test: rename Product label to Item — Product lexes as the
case-insensitive PRODUCT keyword in the OpenGQL grammar, breaking ANTLR
parse of CALL GQL("INSERT (n:Product ...)") (test 65)
- gql_function.cpp: restrict the DDL pass-through fallback to a small
allowlist (CREATE/DROP/ALTER NODE|REL|EDGE TABLE, COPY, LOAD FROM);
other GQL syntax errors now raise 'Failed to parse GQL query: <query>'
instead of leaking core Parser exceptions (test 58)
- gql_function.cpp/transformer: emulate 'CREATE GRAPH IF NOT EXISTS' by
checking the graph catalog at rewrite time and no-opping when the graph
already exists — LadybugDB Cypher has no IF NOT EXISTS for CREATE GRAPH
(test 60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GQL extension: CALL GQL('query') translating GQL to Cypher
(e.g., INSERT -> CREATE) since GQL and Cypher share common syntax