Repository navigation
fix: remove Math.max(0) clamp on netYield in depositor yield history - #1969
Merged
Merged
Conversation
…ncy.namespace - auditLogService.pagination.test.ts: Fixed mock setup order (imports after unstable_mockModule), pageQuery() to return last SELECT call, cursor parsing with decodeCursor(), filter count expectation (7 not 8), SQL trim(), and cursor ID value (299 not 298) - idempotency.namespace.test.ts: Already had correct per-wallet namespacing mock setup; passes when run without test interference
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const cacheKeysRead = () => | ||
| asMock(cacheService.get).mock.calls.map(([key]) => String(key)); | ||
| const aliceCacheKey = `idemp:${ALICE}:shared-key`; | ||
| const aliceLockKey = `idemp:${ALICE}:shared-key:lock`; |
| return request; | ||
| }; | ||
|
|
||
| const aliceCacheKey = `idemp:${ALICE}:shared-key`; |
|
|
||
| const aliceCacheKey = `idemp:${ALICE}:shared-key`; | ||
| const aliceLockKey = `idemp:${ALICE}:shared-key:lock`; | ||
| const bobCacheKey = `idemp:${BOB}:shared-key`; |
| const aliceCacheKey = `idemp:${ALICE}:shared-key`; | ||
| const aliceLockKey = `idemp:${ALICE}:shared-key:lock`; | ||
| const bobCacheKey = `idemp:${BOB}:shared-key`; | ||
| const bobLockKey = `idemp:${BOB}:shared-key:lock`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Math.max(0, ...) clamp on netYield in buildDepositorYieldHistory so that the returned YieldHistoryPoint[] reflects the true signed difference (currentValue - depositedValue), including negative values. Previously, any bucket where a depositor's current position was worth less than their cost basis was reported as netYield: 0, hiding real losses from the yield-history chart/API response.
Changes:
Testing:
closes #1856