Rename self-references + wire up the new GET /health endpoint - #10
Merged
Conversation
- frontend package name, README heading - docs/backend-sync.md: new repo and workflow names; embedded sync workflow YAML now matches python-copier-template PR #41 verbatim backend/ references (copier answers, pyproject homepage) are bot-owned and get updated by the first sync after python-copier-template#41. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011texLkDBELWbXsBf6San3M
- backend/app/api.py: byte-identical copy of the updated template
render (endpoint added upstream in python-copier-template#41); the
first sync produces zero diff for this file
- compose.yaml: backend healthcheck against /health (python urllib, no
curl in the image) and frontend depends_on service_healthy
- Contract workflow: wait on /health and assert its response
- Docker workflow: readiness poll via /api/health through nginx
- README: /health documented as the stable endpoint to keep
Verified locally: compose stack reports backend healthy, frontend
starts only after health, /api/health -> {"status":"ok"} through nginx,
version and predict endpoints still green; backend ruff/ty/pytest pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011texLkDBELWbXsBf6San3M
albertotb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups in one, step by step with python-copier-template#41:
Rename
react-template→react-fastapi-templatefrontend/package.jsonname (+ lockfile) and README headingdocs/backend-sync.md: repo/workflow names updated; the embedded sync-workflow YAML is a verbatim copy of the one in #41 (also updated to target the new repo name)backend/self-references (.copier-answers.ymlgithub_repo,pyproject.tomlhomepage) — bot-owned, updated by the first sync after #41 mergesGET /health(added upstream in #41, wired up here)backend/app/api.pyis a byte-identical copy of the updated template render, so the first automated sync produces zero diff for itcompose.yaml: backend healthcheck against/health(via python urllib — no curl in the image) and the frontend now waits withdepends_on: condition: service_healthy/health+ assertion of its response/api/healththrough nginx/healthdocumented as the stable endpoint to keep when replacing the example endpoints (compose healthcheck and CI rely on it)Verification (local)
/healthhealthy, frontend starts only after the health gate, and/api/health,/api/and/api/predictall respond through nginx🤖 Generated with Claude Code
https://claude.ai/code/session_011texLkDBELWbXsBf6San3M