Open
Conversation
WPForms provides the ‘Disconnect’ functionality, and it will always remove the connection (which includes API Key, Secret, Tokens etc). There’s no need to go and remove these settings via listening to the `convertkit_api_revoke_tokens` action. Updates tests to confirm token revokation works and WPForms truly removes the credentials upstream.
noelherrick
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the user clicks the
Disconnectlink at WPForms > Settings > Integrations > Kit for the specific Kit connection:oauth/revokeendpointUnlike the other Kit Plugins, WPForms provides this 'Disconnect' functionality, and therefore will always remove the connection, including its v3/v4 credentials. As such, this Plugin doesn't need to listen to the
convertkit_api_revoke_tokenshook to remove credentials, as WPForms always (and already) does this for us when the user clicks Disconnect.Adds named parameters to tests that were missing for consistency.
Testing
testCredentialsAndResourcesAreDeletedOnDisconnect: end to end test confirming that the API Key, API Secret, Access Token and Refresh Token are deleted from the Plugin.testCredentialsDeletedAndInvalidWhenRevoked: integration test confirming that the credentials are deleted from the Plugin and no longer work i.e. are revoked, when the API'srevoke_tokensmethod is called.Checklist