fix(dev): restore tsconfig and fix tsx resolution for dev scripts#2073
Open
evanjacobson wants to merge 2 commits intomainfrom
Open
fix(dev): restore tsconfig and fix tsx resolution for dev scripts#2073evanjacobson wants to merge 2 commits intomainfrom
evanjacobson wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the monorepo restructure (#1315),
pnpm dev:startfails becausetsxcan't find a tsconfig when running dev scripts from the repo root — the roottsconfig.jsonandtsconfig.scripts.jsonwere moved toapps/web/without replacements.This adds a minimal root
tsconfig.jsonscoped todev/**/*andscripts/**/*, plus atsconfig.scripts.jsonalias for backward compatibility. It also fixes two related issues:tsxunreachable in tmux — commands sent into tmux panes used baretsx, which isn't on PATH without pnpm'snode_modules/.binaugmentation. Changed topnpm exec tsx.dev-start.shstill referenced the pre-restructureapps/web/dev/docker-compose.ymlpath instead ofdev/docker-compose.yml.Verification
pnpm typecheckpassespnpm exec tsx dev/local/dashboard.tsxruns successfully with core and kiloclaw servicespnpm dev:start/pnpm dev:stoplifecycle worksVisual Changes
N/A
Reviewer Notes
The root
tsconfig.scripts.jsonexists becausetsxcaches the tsconfig filename in theTSX_TSCONFIG_PATHenv var, which can persist across tmux sessions from before the restructure. It's a one-lineextends— zero maintenance cost.