Improved contrast for copy-toast in dark mode#170
Open
yixun-chen wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Improved contrast for copy-toast in dark mode#170yixun-chen wants to merge 1 commit intoKhronosGroup:mainfrom
yixun-chen wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
In dark mode, the .copy-toast background (using --doc-font-color) becomes light-colored, while the text color was hardcoded to white. This resulted in invisible text. This PR changes the text color to var(--body-background) to ensure high contrast and visibility in both light and dark themes.
Contributor
Author
|
Here are the screenshots for verification(I tested it in my browser): Before: After: As shown, the "Copied!" text was invisible in dark mode due to the hardcoded white color. Using |
Contributor
Author
|
Hi, sorry to bother you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark mode, the .copy-toast background (using --doc-font-color) becomes light-colored, while the text color was hardcoded to white. This resulted in invisible text.
This PR changes the text color to var(--body-background) to ensure high contrast and visibility in both light and dark themes.