mpu6050:Add shell script for get temperature from mpu6050 by ghostzero2000 · Pull Request #130 · Kernel-GL-HRK/gl-kernel-training-2019

ghostzero2000 · 2019-12-03T14:02:39Z

Add shell script for getting temperature from mpu6050 , log file with i2c commands and screenshot with it.

yekovalyov · 2019-12-04T09:50:46Z

Please attach the results of script's execution.

ghostzero2000 · 2019-12-05T13:13:50Z

Added the screenshot with the result of the script's execution.

yekovalyov · 2019-12-06T06:47:49Z

Did You check the value of temperature? Are they correct?

ghostzero2000 · 2019-12-07T13:01:18Z

Hello. I found a mistake, I perceived the variable as unsigned. Now it is a value 16 bit signed

yekovalyov · 2019-12-08T11:41:37Z

Please attach the results of script execution in format of text file.

ghostzero2000 · 2019-12-09T12:39:25Z

Attached file "mpu6050_get_temp_C_and_F.log" which content of script execution.

ghostzero2000 · 2019-12-16T14:46:54Z

Like I cleaned everything.

yekovalyov · 2019-12-26T18:31:37Z

+function get_temperature {
+    H_BYTE_MPU6060=$(i2cget -y 0 0x68 0x41 b)
+    L_BYTE_MPU6060=$(i2cget -y 0 0x68 0x42 b)
+    TWO_BYTE_HEX="${H_BYTE_MPU6060:2}${L_BYTE_MPU6060:2}"
+    TWO_BYTE_DEC_convert=$(conv_16_bit_hex_dec_signed $TWO_BYTE_HEX )
+#    echo "TWO_BYTE_DEC=$TWO_BYTE_DEC_convert"
+    echo "Temp TWO_BYTE_HEX $( echo "scale=3; $TWO_BYTE_DEC_convert/340+36.53" | bc)"
+    echo "Temp Fahrenheit $(echo "scale=3; (($TWO_BYTE_DEC_convert/340+36.53)*9)/5+32" | bc)"
+
+}


Can You implement the conversation without additional call of printf and using out from i2cget with option -w

The changes are not implemented.

ghostzero2000 · 2020-01-08T21:18:51Z

Update shell script with i2cget option w

yekovalyov · 2020-01-10T17:50:14Z

The additional commit from other task was included in this PR. Please rebase your PR.

ghostzero2000 · 2020-01-11T12:26:43Z

In the pull request is one commit that belongs to this task.

yekovalyov · 2020-01-14T13:22:38Z

+    echo "Temp TWO_BYTE_HEX $( echo "scale=3; $TWO_BYTE_DEC_convert/340+36.53" | bc)"
+    echo "Temp Fahrenheit $(echo "scale=3; (($TWO_BYTE_DEC_convert/340+36.53)*9)/5+32" | bc)"
+	LONG_WORD=$(i2cget -y 0 0x68 0x41 w)
+	CONVERT_LONG_WORD=$(((LONG_WORD & 0xFF)<<8 | (LONG_WORD>>8) & 0xFF))
+	(( CONVERT_LONG_WORD > 32767 )) && (( CONVERT_LONG_WORD -= 65536 ))
+	Celsiy=$(bc -l <<< "scale=4;$CONVERT_LONG_WORD/340+36.53")
+	Fahrenheit=$(bc -l <<< "scale=4;$Celsiy*9/5+32")


What is the reason for different scale for file and for stdout output? Is the 4th digit after point significant?

Signed-off-by: Vladyslav <omelya1998chirk@gmail.com>

ghostzero2000 · 2020-01-14T21:52:13Z

The conversion from a simple fraction to a decimal fraction makes rounding significant for any number of decimal places.

yekovalyov · 2020-01-15T12:21:25Z

+Temp Celsiy 27.401
+Temp Fahrenheit 81.321
+Temp long_word
+Celsius 27.40058823529411764706 


What is the value of least significant bit for this sensor? Are 20 digits after comma enough?

ghostzero2000 added the ready The PR is ready for review (set by author). label Dec 3, 2019

ghostzero2000 requested a review from yekovalyov December 3, 2019 14:02

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Dec 4, 2019

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from ab047e5 to 20853cd Compare December 5, 2019 13:12

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Dec 5, 2019

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Dec 6, 2019

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from 20853cd to 67b8175 Compare December 7, 2019 12:58

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Dec 8, 2019

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Dec 8, 2019

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from 67b8175 to b79cd83 Compare December 9, 2019 12:37

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Dec 9, 2019

yekovalyov reviewed Dec 16, 2019

View reviewed changes

Comment thread mpu6050_userspace/mpu6050_get_temp_C_and_F.sh Outdated

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Dec 16, 2019

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from b79cd83 to 76f161e Compare December 16, 2019 14:45

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Dec 16, 2019

yekovalyov reviewed Dec 26, 2019

View reviewed changes

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Dec 26, 2019

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch 3 times, most recently from bc1f8b5 to 7071531 Compare January 8, 2020 21:14

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Jan 8, 2020

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Jan 10, 2020

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from 7071531 to 7323aae Compare January 11, 2020 12:23

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Jan 11, 2020

yekovalyov reviewed Jan 14, 2020

View reviewed changes

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Jan 14, 2020

mpu6050:Add shell script for get temperature from mpu6050

aa9eb31

Signed-off-by: Vladyslav <omelya1998chirk@gmail.com>

ghostzero2000 force-pushed the mpu6050_userspace_solution_ver_02 branch from f37e80a to aa9eb31 Compare January 14, 2020 21:46

ghostzero2000 added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Jan 14, 2020

yekovalyov reviewed Jan 15, 2020

View reviewed changes

yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Jan 15, 2020

Conversation

ghostzero2000 commented Dec 3, 2019

Uh oh!

yekovalyov commented Dec 4, 2019

Uh oh!

ghostzero2000 commented Dec 5, 2019

Uh oh!

yekovalyov commented Dec 6, 2019

Uh oh!

ghostzero2000 commented Dec 7, 2019

Uh oh!

yekovalyov commented Dec 8, 2019

Uh oh!

ghostzero2000 commented Dec 9, 2019

Uh oh!

Uh oh!

ghostzero2000 commented Dec 16, 2019

Uh oh!

yekovalyov Dec 26, 2019

Choose a reason for hiding this comment

Uh oh!

yekovalyov Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

ghostzero2000 commented Jan 8, 2020

Uh oh!

yekovalyov commented Jan 10, 2020

Uh oh!

ghostzero2000 commented Jan 11, 2020

Uh oh!

yekovalyov Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

ghostzero2000 commented Jan 14, 2020

Uh oh!

yekovalyov Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants