feat: provide option to start with recording page#660
Draft
GitMensch wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Imo, For your use-case, I think we should rather approach it differently, i.e. like you say here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft to showcase the working feature.
The main question is: Do we want a single option (as in this PR) that opens the recording page when no files are given (then we may want to output an error if the
QStringList filesis not empty); or do we want an option like "openPage" with a set of names that works in general (also for files opened, which then needs to be postponed after a possible load is done to switch from the summary page to the specified one).... and of course I'm open to a better name than
recordoropenPage.after everything is clear the README will get updated as well to include the new option in the help output