Skip to content

gradle test fails due to wrong DATASET_URL #45

Open

Description

@dabg3

TestData.java
private static final String DATASET_URL = "https://panako.be/releases/Panako-test-dataset/"

it should be:
private static final String DATASET_URL = "https://0110.be/releases/Panako/Panako-test-dataset/"

However, the main problem is having a dependency on a remote web server which makes a test not repeatable (The R in F.I.R.S.T) under certain conditions.
As Robert Martin writes in Clean Code:

Tests should be repeatable in any environment [...] and on your laptop while riding home on the train without network

Caching partially solves this problem, I would add the required files in the repo since the build fails without working tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions