fix(core): write the final fingerprints in cache and print mode - #72
Closed
gonzafirewall wants to merge 1 commit into
Closed
gonzafirewall wants to merge 1 commit into
gonzafirewall wants to merge 1 commit into
Conversation
At the end of the stream, query, store and delete handle the last batch of fingerprints, but cache and print mode never wrote it. The .tdb missed the fingerprints at the end of the audio while the .meta counted them. Since store goes through cache mode, store lost them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Closing: the same fix landed in f81cda5 and was released in v3.1.1. Thanks! |
Owner
|
Hi, thanks for the PR and the checks. I have been developing a bit in paralel to this but much appreciated. Pease do keep testing and reporting or PRing. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of the stream, query, store and delete handle the last batch of fingerprints, but cache and print mode never wrote it. The
.tdbtherefore missed the fingerprints at the end of the audio, while the.metacounted them. Sincestorenow goes through cache mode,storeloses them too.Example with a 20 s file:
.metasaysfingerprints=584, but the.tdbhas 539 rows. None of the rows is after 17.48 s, and a query match at 16.3–18.8 s in the reference is lost. With this fix the.tdbhas 584 rows and the match is found again.zig build test: 58/60 tests pass and 2 are skipped. One test step fails to link (olaf_config_ep_error,olaf_config_matcher_error), the same as onmaster.🤖 Generated with Claude Code