Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport timestamp headers currently use
yyyy-MM-dd HH:mm:ss:ffffff Z, which stock date parsers cannot read. This completes the writer portion of #3645: both timestamp writers now emit invariant round-trip ("o") UTC values, preserving all seven fractional-second digits. Readers continue accepting legacy headers. No schema changes.The regression covers scheduling, expiration and sent timestamps, non-UTC input, three cultures, null headers, and legacy timestamps through binary persistence. Migration guidance explains receiver-first rollout.
Release sequencing — draft
This must not ship to mixed fleets until receivers can read the new format. The 6.x reader change merged in #3656; the 5.x backport merged in #4583. NuGet's latest 5.x package at verification was 5.41.0, and its tagged source still uses legacy-only readers. The backport needs a published release and a documented receiver version floor before this writer change is released to those fleets. Maintainer confirmation of release sequencing is needed before marking this ready.
Verification
ignoring_traffic_for_every_session_on_a_host.without_the_rule_the_same_traffic_holds_the_session_open; expected timeout, observed completion. Its entire class passed 9/9 in an isolated rerun.exception_event_on_failed_attempt_span_5311.each_attempt_of_a_retried_then_dead_lettered_message_records_its_exception; expected two spans, observed zero. It also fails with the original timestamp writers restored.protocfailing on this ARM Mac (Bad CPU type in executable). CoreTests builds succeeded on both targets.--verify-no-changes. The test style check excludes IDE1006 because this existing fixture uses the repository's snake_case test naming; production style checks include naming.git diff --checkpassed. Final review found no additional implementation issues.