Repository navigation
Follow-ups: Kafka replay GroupId docs + kafka-replay --group-id (#5306), same-type OnException docs (#5357) - #5380
Merged
Conversation
…ka-replay Follow-up to #5343. The Kafka guide now says when to set a fixed replay group id (brokers that authorize consumer groups by literal name only), with the API and CLI forms. The kafka-replay command takes --group-id and passes it through to KafkaReplayRequest.GroupId. Tests: a real-broker replay run twice under one requested group id, and the CLI input-to-request mapping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U
#5357) Two middleware OnException methods for one exception type now share a catch block in registration order, and an early exit stops the rest. The docs say so, and recommend an explicit try/catch where the order is in doubt, plus checking the generated code with codegen preview/write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U
jeremydmiller
changed the title
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5343 (closes the loop on #5306).
What changed
Docs:
docs/guide/messaging/transports/kafka.md("Replaying a Topic") now explains when to setKafkaReplayRequest.GroupId. You need it when brokers authorize consumer groups by literal name only, because then a generated{live group}-replay-{guid}name can never be granted ahead of time. The section shows the API and CLI forms, and notes that the Assign-only, no-commit consumer makes a fixed, reused name safe.CLI:
kafka-replaytakes--group-id <name>and passes it through toKafkaReplayRequest.GroupId. The request building is pulled intoKafkaReplayCommand.BuildRequestso it can be tested without a host.Docs (follow-up to Merge OnException handlers for the same exception type into one catch clause #5357):
docs/guide/http/exception-handling.mdhas a new subsection, "More than one middleware catching the same exception type". It explains that theOnExceptionmethods share onecatchblock in registration order and that an early exit stops the later ones. It recommends an explicittry/catchwhen the order is in doubt, and checking the generated code withcodegen preview/codegen write.Tests
replays_can_reuse_one_requested_group_id: replays twice against a real broker under the same requested group id, and each run replays the record.the_replay_command_passes_the_group_id_flag_through: checks the mapping from CLI input to the request.Locally:
Wolverine.Kafka.Tests --filter-class "*kafka_replay_envelope_and_group"passes 13/13 on net10.0, andWolverine.Kafkabuilds with-f net9.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U