Repository navigation
Conversation
Owner
|
Cool, I think people will be excited to have this available in the built-in plugin browser. @Malik12tree for visibility on the unofficial plugin being replaced, I don't think there should be any concerns about that. Some feedback from testing the plugin:
|
# Conflicts: # plugins.json
- Fix attachments panel positioning, position offsets, typescript issues, and keyframe wrapping - Preserve unmodelled Vintage Story keys across a Blockbench round trip - Unify permission checks; add about.md and format definition info - Update plugin blockbench icon
Author
|
Sorry about the close/reopen due to my weak Git-fu but looks correctly rebased now. It should now validate fully, ask for permissions only once and have an icon 👍 We also fixed 2-3 bugs in the plugin itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, official Vintage story guy here. Since some of our teams now start using Blockbench we've decided to become the official maintainer of this plugin, hence I propose to also remove the outdated community provided plugin in the same PR. This has been agreed upon by its 2 authors, codename_b (Anego Studios Team member) and DarkLuke1111 (VS community contributor), but i haven't contacted the author of the old plugin.
This version fully supports animation, as well as different animation interpolation modes.
I ran the validator, fixed some issues, but I'm afraid I don't understand how to fix this issue:
Metadata mismatch: "about" is set to undefined in plugins.json and "A Blockbench plugin that adds support for Vintage Story models" in JS fileWhen I add an about section of the plugins.json then the error changes that this should be in the about.md, which already exists.
This PR would also obsolete #460