Update NRL adp-preprocessors, add sdp-preprocessors#2060
Open
climbfuji wants to merge 14 commits into
Open
Conversation
…ssors/package.py: set correct URLs, add new version, copy missing 'etc' directory
…ssors/package.py for oneAPI
climbfuji
commented
Jul 15, 2026
Comment on lines
+23
to
+29
| # These are not official versions; 1.1.1 lives in @climbfuji's fork. | ||
| version("1.1.2", commit="729b0e7572a497b1103d0b8b1e6ff3972efd0d29") | ||
| version( | ||
| "1.1.1", | ||
| git="https://github.nrlmry.navy.mil/climbfuji/adp-preprocessors.git", | ||
| commit="c6f15e46496309c3893416ba4ccec7f003b93550" | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
There are no official versions/tags that can be built with spack-stack, just commits. None of these have ever been used, hence we can rewind the clock and use these version numbers. Makes it easier in the future.
climbfuji
commented
Jul 15, 2026
climbfuji
marked this pull request as ready for review
July 15, 2026 21:43
…p_preprocessors/package.py
…p_preprocessors/package.py
climbfuji
commented
Jul 17, 2026
Comment on lines
+94
to
+95
| #test_script = which(join_path(self.stage.source_path, "src/script/run_all_test.sh")) | ||
| #test_script() |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| #test_script = which(join_path(self.stage.source_path, "src/script/run_all_test.sh")) | |
| #test_script() |
Remove this when updating the hash for 0.1.0 and the comment above the hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
adp-preprocessorsafter merging spack-related PRs into the authoritative code base. Introduce new packagesdp-preprocessors.Dependencies
Issues addressed
NRL internal issue.
Applications affected
FALCON DA
Systems affected
None directly
Testing
adp-preprocessors andsdp-preprocessorson Narwhal and Nautilus, each time withgcc@13andoneapi@2024/oneapi@2025`adp-preprocessorsandsdp-preprocessorson my dev box withgcc@14andoneapi@2025adp-preprocessorsandsdp-preprocessorstests as part ofspack install:spack install --verbose --test=root sdp-preprocessors adp-preprocessors ...Checklist
All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged