Skip to content

Allow QuickCheck 2.18#5379

Merged
f-f merged 1 commit into
mainfrom
f-f/allow-quickcheck-218
Jun 24, 2026
Merged

Allow QuickCheck 2.18#5379
f-f merged 1 commit into
mainfrom
f-f/allow-quickcheck-218

Conversation

@f-f

@f-f f-f commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

We allow QuickCheck@2.18 by using the machinery introduced in IntersectMBO/cardano-base#652

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@github-project-automation github-project-automation Bot moved this to In Progress in Ouroboros Network May 28, 2026
@f-f f-f force-pushed the f-f/allow-quickcheck-218 branch from 0749df0 to cb58582 Compare June 1, 2026 14:15
@f-f f-f force-pushed the f-f/allow-quickcheck-218 branch 4 times, most recently from c2bf86d to 8b4dcb8 Compare June 18, 2026 09:08
@f-f f-f marked this pull request as ready for review June 18, 2026 09:10
@f-f f-f requested a review from a team as a code owner June 18, 2026 09:10

@coot coot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot enabled auto-merge June 24, 2026 09:17
@coot

coot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@f-f you need to force push the PR - it seems hydra got stuck.

@f-f f-f force-pushed the f-f/allow-quickcheck-218 branch from 8b4dcb8 to 1c6d1cc Compare June 24, 2026 11:20
@f-f f-f force-pushed the f-f/allow-quickcheck-218 branch from 1c6d1cc to d94584b Compare June 24, 2026 12:26
@coot coot added this pull request to the merge queue Jun 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 24, 2026
@f-f f-f added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit d7736b7 Jun 24, 2026
18 of 19 checks passed
@f-f f-f deleted the f-f/allow-quickcheck-218 branch June 24, 2026 14:51
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Ouroboros Network Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants