Skip to content

Avoid pipelining of future blocks#4334

Closed
bartfrenk wants to merge 4 commits into
mainfrom
bartfrenk/private-16/no-future-blocks-pipelining
Closed

Avoid pipelining of future blocks#4334
bartfrenk wants to merge 4 commits into
mainfrom
bartfrenk/private-16/no-future-blocks-pipelining

Conversation

@bartfrenk

@bartfrenk bartfrenk commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Description

Supersedes #4310.

Updates chain selection to first check for blocks from the future before setting the tentative header. This avoids pipelining blocks from the future.

  • 1bc9135 by @nfrisby.
  • Testing to ensure future blocks are not emitted to followers.

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@bartfrenk bartfrenk force-pushed the bartfrenk/private-16/no-future-blocks-pipelining branch from 1c11894 to b4107ff Compare February 2, 2023 13:58
@coot coot added the consensus issues related to ouroboros-consensus label Oct 25, 2024
@dnadales

Copy link
Copy Markdown
Member

Closing this as stale.

@dnadales dnadales closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus issues related to ouroboros-consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants