Skip to content

Support data-elevator 0.3.*#857

Open
mwihoti wants to merge 1 commit into
IntersectMBO:mainfrom
mwihoti:main
Open

Support data-elevator 0.3.*#857
mwihoti wants to merge 1 commit into
IntersectMBO:mainfrom
mwihoti:main

Conversation

@mwihoti

@mwihoti mwihoti commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Description

Relaxes data-elevator bounds to allow ^>=0.3.

Checklist

  • Read our contribution guidelines at CONTRIBUTING.md, and make sure that this PR complies with the guidelines.
  • Tests passes

@mwihoti

mwihoti commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I noticed you had already self-assigned on #856, after I opened pr, I have pushed changes incase of any update let me know

@jorisdral jorisdral linked an issue Jun 29, 2026 that may be closed by this pull request
@jorisdral

Copy link
Copy Markdown
Collaborator

Hi, I noticed you had already self-assigned on #856, after I opened pr, I have pushed changes incase of any update let me know

Thanks! no worries

@jorisdral jorisdral left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this issue!

Comment thread lsm-tree/CHANGELOG.md Outdated
Comment thread lsm-tree/lsm-tree.cabal
Comment thread cabal.project.release Outdated
Comment thread cabal.project.release Outdated
@mwihoti mwihoti force-pushed the main branch 2 times, most recently from 9d94438 to 0f8ab50 Compare June 29, 2026 12:16
@mwihoti

mwihoti commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

all tests passed after adding data-elevator 0.3, thank you for review, I've made necessary changes
image

Comment thread lsm-tree/CHANGELOG.md
Comment thread lsm-tree/CHANGELOG.md Outdated

@jorisdral jorisdral left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change, and then we can merge. Could you also make sure to squash your commits so that is just one?

Comment thread lsm-tree/CHANGELOG.md Outdated
#836](https://github.com/IntersectMBO/lsm-tree/pull/836).
* Support `containers-0.8`. See [PR
#836](https://github.com/IntersectMBO/lsm-tree/pull/836).
* Support `data-elevator-0.3`. See [issue #856](https://github.com/IntersectMBO/lsm-tree/issues/856) and [PR #857](https://github.com/IntersectMBO/lsm-tree/pull/857).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left over:

Suggested change
* Support `data-elevator-0.3`. See [issue #856](https://github.com/IntersectMBO/lsm-tree/issues/856) and [PR #857](https://github.com/IntersectMBO/lsm-tree/pull/857).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I have updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support data-elevator-0.3

2 participants