fix(metadata-validation): block private fetch targets#4177
Open
tianpeng-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch adds outbound URL validation before
metadata-validationfetches a submitted metadata URL.It blocks:
localhost/.localhostThe goal is to prevent the metadata validator from being used as an SSRF proxy for internal or local network targets.
Related issue
Fixes #4142
Verification
npm test -- --runInBand(7/7 tests)npm run buildgit diff --checkI also tried a no-fix ESLint command, but the current project dependency is ESLint 10 while the project still uses
.eslintrc.js; ESLint exits before checking files because it expectseslint.config.*.Notes
No production probing was performed. The new regression tests mock DNS resolution and verify that blocked targets are rejected before
HttpService.getis called and again inside the actual request agent lookup.