Skip to content

Optimize sentry integration#2449

Open
kneerose wants to merge 3 commits into
developfrom
feat/optional-sentry-integration
Open

Optimize sentry integration#2449
kneerose wants to merge 3 commits into
developfrom
feat/optional-sentry-integration

Conversation

@kneerose

@kneerose kneerose commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

List of changes

  • Make sentry initialize optional for frontend and backend
  • only register the sentry if the "sentry dsn" is available on frontend and sentryEnv is not "qa" in the backend

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions

github-actions Bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions

github-actions Bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions

github-actions Bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose force-pushed the feat/optional-sentry-integration branch from ce8b20e to c35033b Compare December 11, 2024 08:32
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose

Copy link
Copy Markdown
Contributor Author

@MSzalowski , could you please review this? Feel free to make any updates or changes as needed.

@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@mesudip

mesudip commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

@MSzalowski , can you review and determine whether or not it is still relevant?

@MSzalowski

Copy link
Copy Markdown
Contributor

@kneerose Can we merge this PR?

Comment thread govtool/frontend/src/main.tsx
@kneerose kneerose force-pushed the feat/optional-sentry-integration branch from c35033b to 464111c Compare January 30, 2025 10:07
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip January 30, 2025 11:02
@kneerose kneerose requested a review from MSzalowski January 31, 2025 06:07
@kneerose kneerose requested a review from placek January 31, 2025 06:07
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions

Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@kneerose

Copy link
Copy Markdown
Contributor Author

@MSzalowski can you review this again? also please look at this ticket
#2776

@mesudip mesudip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mesudip

mesudip commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Assigned to @MSzalowski for backend changes

Todo

  • When sentrydsn is not set in config file or is empty then sentry will be disabled.

@kneerose kneerose linked an issue May 19, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend doesn't log on console

4 participants