Skip to content

Update sklearnex gpu to use array_api_dispatch and dpnp - #218

Open
ethanglaser wants to merge 3 commits into
IntelPython:mainfrom
ethanglaser:dev/eglaser-array-api-gpu
Open

Update sklearnex gpu to use array_api_dispatch and dpnp#218
ethanglaser wants to merge 3 commits into
IntelPython:mainfrom
ethanglaser:dev/eglaser-array-api-gpu

Conversation

@ethanglaser

Copy link
Copy Markdown
Contributor

Description


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Comment thread README.md Outdated
conda env create -n rapids --solver=libmamba -f envs/conda-env-rapids.yml
```

GPU benchmarks using `sklearnex`'s `device: gpu` rely on scikit-learn's Array API support (`array_api_dispatch`), which requires `SCIPY_ARRAY_API=1` to be set in the environment before running:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it could be set inside the python process instead.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could but I don't think this is a great way to handle it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanglaser What would be the downside?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment thread sklbench/benchmarks/sklearn_estimator.py Outdated
Comment thread configs/common/sklearn.json Outdated
@ethanglaser
ethanglaser marked this pull request as ready for review August 25, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants